From: Rick Vernam <rtvernam@gmail.com>
To: marcandre.lureau@redhat.com
Cc: qemu-devel@nongnu.org, rtvernam@gmail.com
Subject: [PATCH] ui/dbus: forward guest clipboard grabs that lack a serial
Date: Mon, 7 Sep 2026 16:12:33 -0500 [thread overview]
Message-ID: <20260907211233.501672-1-rtvernam@gmail.com> (raw)
dbus_clipboard_update_info() drops any incoming grab whose
QemuClipboardInfo has no serial number:
if (self_update || !info->has_serial) {
return;
}
For grabs coming from ui/vdagent.c, has_serial is only set when the
guest's vdagent client has negotiated VD_AGENT_CAP_CLIPBOARD_GRAB_SERIAL
(see vdagent_clipboard_recv_grab()). When the guest doesn't negotiate
it, the grab is silently dropped here and never forwarded to the
D-Bus display client via Clipboard.Grab.
It seems other protocols (ui/gtk-clipboard.c, ui/vnc-clipboard.c) do not
incorporate a validation on has_serial, so this patch matches their
behavior.
Signed-off-by: Rick Vernam <rtvernam@gmail.com>
---
ui/dbus-clipboard.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/dbus-clipboard.c b/ui/dbus-clipboard.c
index 90318384ee..1389ec0edc 100644
--- a/ui/dbus-clipboard.c
+++ b/ui/dbus-clipboard.c
@@ -72,7 +72,7 @@ dbus_clipboard_update_info(DBusDisplay *dpy, QemuClipboardInfo *info)
return;
}
- if (self_update || !info->has_serial) {
+ if (self_update) {
return;
}
--
2.55.0
next reply other threads:[~2026-09-07 21:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 21:12 Rick Vernam [this message]
2026-09-08 7:00 ` [PATCH] ui/dbus: forward guest clipboard grabs that lack a serial Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260907211233.501672-1-rtvernam@gmail.com \
--to=rtvernam@gmail.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.