From: David Laight <david.laight.linux@gmail.com>
To: "Ömer Mete Kaya" <omermetekaya0@gmail.com>
Cc: oneukum@suse.com, netdev@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH net v2] usbnet: fix smp_processor_id() use in preemptible context
Date: Mon, 7 Sep 2026 21:23:08 +0100 [thread overview]
Message-ID: <20260907212308.420701cf@pumpkin> (raw)
In-Reply-To: <20260907185408.660755-1-omermetekaya0@gmail.com>
On Mon, 7 Sep 2026 21:52:20 +0300
Ömer Mete Kaya <omermetekaya0@gmail.com> wrote:
> Hi Oliver,
>
> Thank you for the review. You are right.
>
> I used local_irq_save()/restore() thinking that softirq writers could
> race on tstats. After checking the tstats update paths, I agreed that
> preemption protection is sufficient for these accesses.
>
>
> I will send v3 using preempt_disable()/preempt_enable() as suggested.
Shouldn't you use get_cpu_ptr() and put_cpu_ptr() ?
David
>
> Best regards,
>
> Ömer Mete Kaya
>
next prev parent reply other threads:[~2026-09-07 20:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 16:54 [PATCH] usbnet: fix smp_processor_id() use in preemptible context Ömer Mete Kaya
2026-09-05 22:45 ` [PATCH net v2] " Ömer Mete Kaya
2026-09-07 11:38 ` Oliver Neukum
2026-09-07 18:52 ` Ömer Mete Kaya
2026-09-07 20:23 ` David Laight [this message]
2026-09-07 21:45 ` [PATCH net v4] " Ömer Mete Kaya
2026-09-09 21:47 ` netdev-bot+sashiko
2026-09-10 9:01 ` David Laight
2026-09-07 19:05 ` [PATCH] " Ömer Mete Kaya
2026-09-08 3:43 ` [PATCH net v2] " netdev-bot+sashiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260907212308.420701cf@pumpkin \
--to=david.laight.linux@gmail.com \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=omermetekaya0@gmail.com \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.