All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: tuxdevv <denizgozen61@gmail.com>
Cc: linux-staging@lists.linux.dev, greybus-dev@lists.linaro.org,
	linux-kernel@vger.kernel.org,
	Vaibhav Agarwal <vaibhav.sr@gmail.com>,
	Mark Greer <mgreer@animalcreek.com>,
	Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>
Subject: Re: [PATCH] staging: greybus: fix missing newline in sysfs_emit() format strings
Date: Mon, 7 Sep 2026 18:33:18 +0200	[thread overview]
Message-ID: <2026090758-conjure-parole-ccb1@gregkh> (raw)
In-Reply-To: <20260907071525.43505-1-denizgozen61@gmail.com>

On Mon, Sep 07, 2026 at 10:15:25AM +0300, tuxdevv wrote:
> From: Deniz Gözen <denizgozen61@gmail.com>
> 
> The show functions for the audio module's name, vid, pid, intf_id,
> ip_devices and op_devices sysfs attributes pass format strings to
> sysfs_emit() without a trailing newline. Per sysfs conventions each
> attribute should return content terminated by '\n', and checkpatch.pl
> flags all six calls as missing the terminator.
> 
> Add the missing '\n' to each format string.
> 
> Signed-off-by: Deniz Gözen <denizgozen61@gmail.com>
> ---
>  drivers/staging/greybus/audio_manager_module.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

Please see the mailing list archives for why this change can't be
accepted at the moment.

thanks,

greg k-h

      reply	other threads:[~2026-09-07 16:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-07  7:15 [PATCH] staging: greybus: fix missing newline in sysfs_emit() format strings tuxdevv
2026-09-07 16:33 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026090758-conjure-parole-ccb1@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=denizgozen61@gmail.com \
    --cc=elder@kernel.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mgreer@animalcreek.com \
    --cc=vaibhav.sr@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.