All of lore.kernel.org
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Paul Sajna <sajattack@postmarketos.org>
Cc: Lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Nikita Travkin <nikitos.tr@gmail.com>,
	Alexey Min <alexeymin@minlexx.ru>,
	linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH RFC 1/3] dt-bindings: leds: aw2013: Add aw2027 compatible and rename to aw20xx
Date: Tue, 8 Sep 2026 19:03:39 +0100	[thread overview]
Message-ID: <20260908-sample-onshore-a2cf8af658b4@spud> (raw)
In-Reply-To: <20260907-aw2013-aw20xx-rename-v1-1-c9a7df12a701@postmarketos.org>

[-- Attachment #1: Type: text/plain, Size: 1967 bytes --]

On Mon, Sep 07, 2026 at 04:47:51PM -0700, Paul Sajna wrote:
> Document the awinic,aw2027, which is very similar to aw2013.
> Rename the driver to support all of the 20xx series.
> 
> Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
> ---
>  .../bindings/leds/{leds-aw2013.yaml => leds-aw20xx.yaml}       | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/leds/leds-aw2013.yaml b/Documentation/devicetree/bindings/leds/leds-aw20xx.yaml
> similarity index 91%
> rename from Documentation/devicetree/bindings/leds/leds-aw2013.yaml
> rename to Documentation/devicetree/bindings/leds/leds-aw20xx.yaml
> index 26238446f2bd..f20b5344e3e1 100644
> --- a/Documentation/devicetree/bindings/leds/leds-aw2013.yaml
> +++ b/Documentation/devicetree/bindings/leds/leds-aw20xx.yaml

Please retain a filename matching a compatible. IOW, leave this alone.
pw-bot: changes-requested

The rest of this is fine, but please note in your commit message what
makes this device different to the existing one.

Thanks,
Conor.

> @@ -1,21 +1,23 @@
>  # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>  %YAML 1.2
>  ---
> -$id: http://devicetree.org/schemas/leds/leds-aw2013.yaml#
> +$id: http://devicetree.org/schemas/leds/leds-aw20xx.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
> -title: AWINIC AW2013 3-channel LED Driver
> +title: AWINIC AW20XX 3-channel LED Driver
>  
>  maintainers:
>    - Nikita Travkin <nikitos.tr@gmail.com>
>  
>  description: |
> -  The AW2013 is a 3-channel LED driver with I2C interface. It can control
> +  The AW20XX is a 3-channel LED driver with I2C interface. It can control
>    LED brightness with PWM output.
>  
>  properties:
>    compatible:
> -    const: awinic,aw2013
> +    enum:
> +      - awinic,aw2013
> +      - awinic,aw2027
>  
>    reg:
>      maxItems: 1
> 
> -- 
> 2.55.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  parent reply	other threads:[~2026-09-08 18:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-07 23:47 [PATCH RFC 0/3] leds: aw2013: Rename aw2013 to aw20xx and add AW2027 support Paul Sajna
2026-09-07 23:47 ` [PATCH RFC 1/3] dt-bindings: leds: aw2013: Add aw2027 compatible and rename to aw20xx Paul Sajna
2026-09-07 23:52   ` sashiko-bot
2026-09-08 18:03   ` Conor Dooley [this message]
2026-09-07 23:47 ` [PATCH RFC 2/3] leds: aw2013: Rename " Paul Sajna
2026-09-07 23:57   ` sashiko-bot
2026-09-07 23:47 ` [PATCH RFC 3/3] leds: aw2013: Add AW2027 support and rename " Paul Sajna
2026-09-08  0:01   ` sashiko-bot
2026-09-09 16:02     ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260908-sample-onshore-a2cf8af658b4@spud \
    --to=conor@kernel.org \
    --cc=alexeymin@minlexx.ru \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=nikitos.tr@gmail.com \
    --cc=pavel@kernel.org \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sajattack@postmarketos.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.