From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org
Cc: Colin Ian King <colin.i.king@gmail.com>,
Jiri Kosina <jkosina@suse.com>, Sasha Levin <sashal@kernel.org>
Subject: [PATCH 5.10.y 3/5] HID: sony: remove redundant assignment
Date: Mon, 7 Sep 2026 20:39:19 -0400 [thread overview]
Message-ID: <20260908003921.1609143-3-sashal@kernel.org> (raw)
In-Reply-To: <20260908003921.1609143-1-sashal@kernel.org>
From: Colin Ian King <colin.i.king@gmail.com>
[ Upstream commit 4e124ed0da2939dcd27849a3d6f41fbc537a20be ]
The variable ret is being assigned a value that is never read
afterwards. The assignment is redundant and can be removed.
Cleans up clang scan build warning:
drivers/hid/hid-sony.c:2020:3: warning: Value stored to 'ret'
is never read [deadcode.DeadStores]
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
Stable-dep-of: 7c65699a3a31 ("HID: sony: clean up device list on probe failure")
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/hid/hid-sony.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
index 621624c1e41b2..182dcd7705862 100644
--- a/drivers/hid/hid-sony.c
+++ b/drivers/hid/hid-sony.c
@@ -1928,8 +1928,6 @@ static int sony_input_configured(struct hid_device *hdev,
} else if (sc->quirks & MOTION_CONTROLLER) {
sony_init_output_report(sc, motion_send_output_report);
- } else {
- ret = 0;
}
if (sc->quirks & SONY_LED_SUPPORT) {
--
2.53.0
next prev parent reply other threads:[~2026-09-08 0:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 13:28 FAILED: patch "[PATCH] HID: sony: clean up device list on probe failure" failed to apply to 5.10-stable tree gregkh
2026-09-08 0:39 ` [PATCH 5.10.y 1/5] HID: sony: remove DualShock4 support Sasha Levin
2026-09-08 0:39 ` [PATCH 5.10.y 2/5] HID: sony: remove duplicate NULL check before calling usb_free_urb() Sasha Levin
2026-09-08 0:39 ` Sasha Levin [this message]
2026-09-08 0:39 ` [PATCH 5.10.y 4/5] HID: sony: use guard() and scoped_guard() Sasha Levin
2026-09-08 0:39 ` [PATCH 5.10.y 5/5] HID: sony: clean up device list on probe failure Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260908003921.1609143-3-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=colin.i.king@gmail.com \
--cc=jkosina@suse.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.