Re: [PATCH v5 4/7] cxo_ol/region: Name the interleave locals in cxl_port_setup_targets()

[Jonathan Cameron <jic23@kernel.org>]

On Thu,  3 Sep 2026 16:23:46 -0700
Alison Schofield <alison.schofield@intel.com> wrote:

> cxl_port_setup_targets() derives the interleave granularity of one decoder
> from the granularity and ways of the decoder above it, and takes that
> decoder's own ways from the topology below it. The values from the level
> above are named parent_iw and parent_ig, but the values being derived are
> the bare iw and ig, so the reader has to work out which level each one
> describes.
> 
> Rename iw and ig to child_iw and child_ig to match the parent_ prefix used
> for the level above.
> 
> No functional change.
> 
> Suggested-by: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>
> Signed-off-by: Alison Schofield <alison.schofield@intel.com>

I was wondering a bit about having ceig and ceiw but those would be
very local so I guess not worth it.

Given how often we use ways_to_eiw() not to make the conversion
but just to check if it is possible, I wonder if a ways_valid()
helper is useful?

static inline int ways_valid(unsigned int ways)
{
	u8 eiw;

	return ways_to_eiw(ways, &eiw);
}

Maybe similar for granularity.  Would remove some confusion over whether
we actually want the encoded values or not, making this function more
readable. I didn't look for whether it was helpful elsewhere.

Anyhow this change is good

Reviewed-by: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>