From: Tao Cui <cui.tao@linux.dev>
To: tj@kernel.org, josef@toxicopanda.com, axboe@kernel.dk
Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, cui.tao@linux.dev,
Tao Cui <cuitao@kylinos.cn>
Subject: [PATCH 4/4] blk-iocost: fix stale comment in ioc_rqos_throttle()
Date: Tue, 8 Sep 2026 10:21:35 +0800 [thread overview]
Message-ID: <20260908022135.1429281-5-cui.tao@linux.dev> (raw)
In-Reply-To: <20260908022135.1429281-1-cui.tao@linux.dev>
From: Tao Cui <cuitao@kylinos.cn>
The comment says that priority-inversion IOs are "punted to
@ioc->aux_iocg", but no aux_iocg field ever existed in struct ioc.
The comment was introduced already stale by commit da437b95db83
("blk-iocost: grab ioc->lock for debt handling"). Update it to
describe the current use_debt / iocg->abs_vdebt mechanism.
Signed-off-by: Tao Cui <cuitao@kylinos.cn>
---
block/blk-iocost.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/block/blk-iocost.c b/block/blk-iocost.c
index 1bf622e39ce4..f99c4f5c83fd 100644
--- a/block/blk-iocost.c
+++ b/block/blk-iocost.c
@@ -2748,10 +2748,11 @@ static void ioc_rqos_throttle(struct rq_qos *rqos, struct bio *bio)
/*
* We're over budget. This can be handled in two ways. IOs which may
- * cause priority inversions are punted to @ioc->aux_iocg and charged as
- * debt. Otherwise, the issuer is blocked on @iocg->waitq. Debt handling
- * requires @ioc->lock, waitq handling @iocg->waitq.lock. Determine
- * whether debt handling is needed and acquire locks accordingly.
+ * cause priority inversions are issued regardless and charged against
+ * @iocg->abs_vdebt as debt. Otherwise, the issuer is blocked on
+ * @iocg->waitq. Debt handling requires @ioc->lock, waitq handling
+ * @iocg->waitq.lock. Determine whether debt handling is needed and
+ * acquire locks accordingly.
*/
use_debt = bio_issue_as_root_blkg(bio) || fatal_signal_pending(current);
ioc_locked = use_debt || READ_ONCE(iocg->abs_vdebt);
--
2.43.0
prev parent reply other threads:[~2026-09-08 2:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 2:21 [PATCH 0/4] blk-iocost: charge flushes and zone appends Tao Cui
2026-09-08 2:21 ` [PATCH 1/4] blk-iocost: charge flushes as pageless random writes Tao Cui
[not found] ` <20260908023455.786E01F00A3A@smtp.kernel.org>
2026-09-08 11:28 ` Tao Cui
2026-09-10 5:41 ` Christoph Hellwig
2026-09-16 8:21 ` Tao Cui
2026-09-08 2:21 ` [PATCH 2/4] blk-iocost: charge zone appends as page-counted sequential writes Tao Cui
2026-09-08 2:21 ` [PATCH 3/4] blk-iocost: account zone append completions in latency stats Tao Cui
2026-09-10 5:39 ` Christoph Hellwig
2026-09-08 2:21 ` Tao Cui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260908022135.1429281-5-cui.tao@linux.dev \
--to=cui.tao@linux.dev \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=cuitao@kylinos.cn \
--cc=josef@toxicopanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.