From: sashiko-bot@kernel.org
To: "Kunwu Chan" <kunwu.chan@gmail.com>
Cc: damon@lists.linux.dev
Subject: Re: [PATCH] mm/damon/tests/core-kunit: improve nr_samples_per_aggr test isolation
Date: Tue, 08 Sep 2026 06:39:14 +0000 [thread overview]
Message-ID: <20260908063914.9322C1F00A3D@smtp.kernel.org> (raw)
In-Reply-To: <20260908063635.2208922-1-kunwu.chan@gmail.com>
> The damon_nr_samples_per_aggr() test sets both intervals to zero,
> which exercises two different fallback paths at once.
>
> Use separate compound initializers for each case so that each case
> tests one fallback path independently. Also make the overflow case
> use an explicit non-zero sample interval so that it does not depend
> on the zero sample interval fallback.
>
> Signed-off-by: Kunwu Chan <kunwu.chan@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260908063635.2208922-1-kunwu.chan@gmail.com?part=1
next prev parent reply other threads:[~2026-09-08 6:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 6:36 [PATCH] mm/damon/tests/core-kunit: improve nr_samples_per_aggr test isolation Kunwu Chan
2026-09-08 6:39 ` sashiko-bot [this message]
2026-09-08 6:48 ` Lian Wang
2026-09-08 13:36 ` SJ Park
2026-09-09 3:54 ` Kunwu Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260908063914.9322C1F00A3D@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=damon@lists.linux.dev \
--cc=kunwu.chan@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.