Re: [PATCH v5 11/24] tools headers UAPI: Sync ELF headers with the kernel sources

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incomplete synchronization of tools/include/uapi/linux/elf.h, missing RISC-V user CFI definitions.
--

commit 9c71e774bdcb446428ed39c9dd1d611efda1f5d1
Author: Thomas Weißschuh <thomas.weissschuh@linutronix.de>

tools headers UAPI: Sync ELF headers with the kernel sources

Pick up changes from the UAPI ELF header files.
This picks up general changes to elf.h, elf-em.h which was forgotten
previously and the new elf-r.h.

> diff --git a/tools/include/uapi/linux/elf.h b/tools/include/uapi/linux/elf.h
> index 5834b83d7f9a4..88bdcbb526c16 100644
> --- a/tools/include/uapi/linux/elf.h
> +++ b/tools/include/uapi/linux/elf.h
[ ... ]
> @@ -376,101 +387,180 @@ typedef struct elf64_shdr {
[ ... ]
> +#define NN_RISCV_VECTOR	"LINUX"
>  #define NT_RISCV_VECTOR	0x901		/* RISC-V vector registers */
> +#define NN_RISCV_TAGGED_ADDR_CTRL "LINUX"
>  #define NT_RISCV_TAGGED_ADDR_CTRL 0x902	/* RISC-V tagged address control (prctl()) */
> +#define NN_LOONGARCH_CPUCFG	"LINUX"

[Severity: Medium]
Are NN_RISCV_USER_CFI and NT_RISCV_USER_CFI missing from this synchronization?

The commit message indicates that this patch syncs ELF headers with the kernel
sources, but the RISC-V user CFI definitions appear to be present in the
core kernel's include/uapi/linux/elf.h and missing here. Could this omission
lead to build failures if userspace tools attempt to use NT_RISCV_USER_CFI for
inspecting shadow stack state?

>  #define NT_LOONGARCH_CPUCFG	0xa00	/* LoongArch CPU config registers */
> +#define NN_LOONGARCH_CSR	"LINUX"
>  #define NT_LOONGARCH_CSR	0xa01	/* LoongArch control and status registers */

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908-vdso-absolute-reloc-v5-0-3a93791af1cf@linutronix.de?part=11