From: Simon Horman <horms@kernel.org>
To: phucduc.bui@gmail.com
Cc: Marcin Wojtas <marcin.s.wojtas@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
davem@davemloft.net, Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: mvpp2: simplify IRQ validity check
Date: Tue, 8 Sep 2026 09:53:50 +0100 [thread overview]
Message-ID: <20260908085350.GO40544@horms.kernel.org> (raw)
In-Reply-To: <20260903075753.346647-1-phucduc.bui@gmail.com>
On Thu, Sep 03, 2026 at 02:57:53PM +0700, phucduc.bui@gmail.com wrote:
> From: bui duc phuc <phucduc.bui@gmail.com>
>
> irq_of_parse_and_map() returns 0 when parsing or mapping an IRQ fails.
> The current condition also checks for negative values, even though
> irq_of_parse_and_map() does not return negative error codes.
>
> Check only for a zero return value to match the semantics of
> irq_of_parse_and_map().
>
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
> ---
>
> Link v1:
> https://lore.kernel.org/all/20260824100758.31622-1-phucduc.bui@gmail.com/
>
> Changes in v2:
> - Drop the Fixes tag and rework the commit message to describe this
> as a cleanup.
> - Add net-next to the --subject-prefix.
Thanks for the updates.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2026-09-08 8:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 7:57 [PATCH net-next v2] net: mvpp2: simplify IRQ validity check phucduc.bui
2026-09-08 8:53 ` Simon Horman [this message]
2026-09-08 13:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260908085350.GO40544@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=marcin.s.wojtas@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=phucduc.bui@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.