From: Damien Le Moal <dlemoal@kernel.org>
To: "Martin K . Petersen" <martin.petersen@oracle.com>,
"James E . J . Bottomley" <James.Bottomley@HansenPartnership.com>,
linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org,
Niklas Cassel <cassel@kernel.org>,
linux-usb@vger.kernel.org, Alan Stern <stern@rowland.harvard.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-s390@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>
Subject: [PATCH v6 19/40] scsi: 3w-xxxx: use 16-bits defined sense codes
Date: Tue, 8 Sep 2026 18:02:47 +0900 [thread overview]
Message-ID: <20260908090308.1085097-20-dlemoal@kernel.org> (raw)
In-Reply-To: <20260908090308.1085097-1-dlemoal@kernel.org>
Modify the function tw_scsi_queue_lck() of the 3w-xxxx driver to use
scsi_set_sense() and replace the hard-coded additional sense codes and
additional sense code qualifiers with the enum values defined in
include/scsi/scsi_sense.h. This helps with code clarity as the sense codes
being processed are easier to test and self-documented.
No functional change intended.
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: Hannes Reinecke <hare@kernel.org>
---
drivers/scsi/3w-xxxx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/3w-xxxx.c b/drivers/scsi/3w-xxxx.c
index 7f7bf5b5640d..11326465abb6 100644
--- a/drivers/scsi/3w-xxxx.c
+++ b/drivers/scsi/3w-xxxx.c
@@ -1977,7 +1977,8 @@ static enum scsi_qc_status tw_scsi_queue_lck(struct scsi_cmnd *SCpnt)
printk(KERN_NOTICE "3w-xxxx: scsi%d: Unknown scsi opcode: 0x%x\n", tw_dev->host->host_no, *command);
tw_dev->state[request_id] = TW_S_COMPLETED;
tw_state_request_finish(tw_dev, request_id);
- scsi_build_sense(SCpnt, 1, ILLEGAL_REQUEST, 0x20, 0);
+ scsi_set_sense(SCpnt, 1, ILLEGAL_REQUEST,
+ INVALID_COMMAND_OP_CODE);
done(SCpnt);
retval = 0;
}
--
2.55.0
next prev parent reply other threads:[~2026-09-08 9:03 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 9:02 [PATCH v6 00/40] Use defined 16-bits ASC/ASCQ combinations Damien Le Moal
2026-09-08 9:02 ` [PATCH v6 01/40] scsi: define all additional sense codes and their qualifiers Damien Le Moal
2026-09-08 9:39 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 02/40] scsi: constants: use defined sense codes Damien Le Moal
2026-09-08 9:12 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 03/40] scsi: constants: rename internal struct field names Damien Le Moal
2026-09-08 9:10 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 04/40] scsi: rename sense field of struct scsi_failure Damien Le Moal
2026-09-08 9:18 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 05/40] scsi: prepare for using 16-bits defined sense codes Damien Le Moal
2026-09-08 9:18 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 06/40] scsi: use struct scsi_sense_hdr to log sense keys and codes Damien Le Moal
2026-09-08 9:17 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 07/40] scsi: core: use 16-bits defined sense codes Damien Le Moal
2026-09-08 9:24 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 08/40] scsi: sd: " Damien Le Moal
2026-09-08 9:26 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 09/40] scsi: sr: " Damien Le Moal
2026-09-08 9:27 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 10/40] scsi: ses: " Damien Le Moal
2026-09-08 9:33 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 11/40] scsi: ch: " Damien Le Moal
2026-09-08 9:32 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 12/40] scsi: st: " Damien Le Moal
2026-09-08 9:33 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 13/40] scsi: device_handlers: hp_sw: " Damien Le Moal
2026-09-08 9:35 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 14/40] scsi: device_handlers: rdac: " Damien Le Moal
2026-09-08 9:37 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 15/40] scsi: device_handlers: emc: " Damien Le Moal
2026-09-08 9:37 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 16/40] scsi: device_handlers: alua: " Damien Le Moal
2026-09-08 9:43 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 17/40] scsi: mpt3sas: " Damien Le Moal
2026-09-08 9:48 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 18/40] scsi: mpi3mr: " Damien Le Moal
2026-09-08 9:42 ` sashiko-bot
2026-09-08 9:02 ` Damien Le Moal [this message]
2026-09-08 9:51 ` [PATCH v6 19/40] scsi: 3w-xxxx: " sashiko-bot
2026-09-08 9:02 ` [PATCH v6 20/40] scsi: leapraid: " Damien Le Moal
2026-09-08 9:50 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 21/40] scsi: megaraid: " Damien Le Moal
2026-09-08 9:48 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 22/40] scsi: myrX: " Damien Le Moal
2026-09-08 9:59 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 23/40] scsi: smartpqi: " Damien Le Moal
2026-09-08 9:54 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 24/40] scsi: qla2xxx: " Damien Le Moal
2026-09-08 9:58 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 25/40] scsi: ps3rom: " Damien Le Moal
2026-09-08 10:05 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 26/40] scsi: lpfc: " Damien Le Moal
2026-09-08 10:03 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 27/40] scsi: stex: " Damien Le Moal
2026-09-08 10:14 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 28/40] scsi: mvumi: " Damien Le Moal
2026-09-08 10:12 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 29/40] scsi: libiscsi: " Damien Le Moal
2026-09-08 10:08 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 30/40] scsi: ibmvscsi_tgt: " Damien Le Moal
2026-09-08 10:18 ` sashiko-bot
2026-09-08 9:02 ` [PATCH v6 31/40] scsi: scsi_debug: " Damien Le Moal
2026-09-08 10:20 ` sashiko-bot
2026-09-08 9:03 ` [PATCH v6 32/40] scsi: hpsa: " Damien Le Moal
2026-09-08 10:19 ` sashiko-bot
2026-09-09 19:02 ` Don.Brace
2026-09-08 9:03 ` [PATCH v6 33/40] scsi: storvsc: " Damien Le Moal
2026-09-08 10:28 ` sashiko-bot
2026-09-08 9:03 ` [PATCH v6 34/40] target: " Damien Le Moal
2026-09-08 10:29 ` sashiko-bot
2026-09-08 9:03 ` [PATCH v6 35/40] usb: storage: " Damien Le Moal
2026-09-08 10:27 ` sashiko-bot
2026-09-08 9:03 ` [PATCH v6 36/40] cdrom: " Damien Le Moal
2026-09-08 10:24 ` sashiko-bot
2026-09-08 9:03 ` [PATCH v6 37/40] ata: libata: " Damien Le Moal
2026-09-08 10:33 ` sashiko-bot
2026-09-08 9:03 ` [PATCH v6 38/40] s390: scsi: " Damien Le Moal
2026-09-08 10:34 ` sashiko-bot
2026-09-08 9:03 ` [PATCH v6 39/40] scsi: cleanup scsi_proto.h Damien Le Moal
2026-09-08 10:36 ` sashiko-bot
2026-09-08 9:03 ` [PATCH v6 40/40] scsi: remove scsi_build_sense() and scsi_build_sense_buffer() Damien Le Moal
2026-09-08 10:32 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260908090308.1085097-20-dlemoal@kernel.org \
--to=dlemoal@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=cassel@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hca@linux.ibm.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.