Re: [PATCH v2] hwmon: (yogafan) Update reference database and contributors for new models

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] Missing driver implementation for the newly documented laptop models (Yoga 740-15IML and IdeaPad 3 15ALC6 Ub), leading to broken hardware support.
- [Low] Misaligned table columns in the reference database.
--

commit 23a8dae262a81e6cfc70a98f694a306fc940b81b
Author: Sergio Melas <sergiomelas@gmail.com>

hwmon: (yogafan) Update reference database and contributors for new models

Add documentation entries for the newly supported laptop models
(Yoga 14cACN 2021, Yoga 740-15IML, and IdeaPad 3 15ALC6 Ub) in the
master reference database table, and include the new contributor.

> Add documentation entries for the newly supported laptop models
> (Yoga 14cACN 2021, Yoga 740-15IML, and IdeaPad 3 15ALC6 Ub) in the
> master reference database table, and include the new contributor.

[Severity: Medium]
Are the changes to drivers/hwmon/yogafan.c missing from this patch?

The commit message states these are newly supported models, but the
driver changes are not included. When booting the kernel on these models,
yoga_fan_probe() will fail.

The documentation specifies unique ACPI paths required for these models,
but the driver relies on DMI matches that map to incorrect fallbacks (e.g.,
Lenovo Yoga providing LPC0 instead of LPCB for the 740-15IML) or incorrect
fan paths (e.g., mapping to FAN0 instead of FANS/FA2S for the IdeaPad 3
Ub). This causes acpi_get_handle() to fail and return -ENODEV.

Should the updates to yogafan_quirks in drivers/hwmon/yogafan.c be
included here?

> diff --git a/Documentation/hwmon/yogafan.rst b/Documentation/hwmon/yogafan.rst
> index 9ff5db5dc08ce..5c21c50b7c4fa 100644
> --- a/Documentation/hwmon/yogafan.rst
> +++ b/Documentation/hwmon/yogafan.rst
> @@ -87,6 +87,9 @@ immediately to ensure the user knows the fan has stopped.
>  
>   MODEL (DMI PN) | FAMILY / SERIES  | EC OFFSET | FULL ACPI OBJECT PATH          | WIDTH  | MULTiplier
>   ----------------------------------------------------------------------------------------------------
> + 82N7           | Yoga 14cACN 2021   | 0x06      | \_SB.PCI0.LPC0.EC0.FANS        |  8-bit | 100
> + 81TD           | Yoga 740-15IML     | 0x06      | \_SB.PCI0.LPCB.EC0.FANS        |  8-bit | 100
> + 82KU           | IdeaPad 3 15ALC6 Ub| 0x06      | \_SB.PCI0.LPC0.EC0.FANS/FA2S   |  8-bit | 100

[Severity: Low]
Does this cause misalignment in the rendered documentation?

The newly added rows exceed the width of the FAMILY / SERIES column header.
This shifts the subsequent pipe separators by up to 3 spaces and breaks the
literal text block table alignment.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908095009.2227661-1-sergiomelas@gmail.com?part=1