Re: [PATCH v1 net 4/4] neighbour: Skip default parms when resumed in neightbl_dump_info().

[Ido Schimmel <idosch@nvidia.com>]

On Mon, Sep 07, 2026 at 09:57:55PM +0000, Kuniyuki Iwashima wrote:
> neightbl_dump_info() calls neightbl_fill_info() in each loop
> to render the default parms.
> 
> If there are many devices and neightbl_fill_param_info() failed,
> neightbl_fill_info() is called again when the dump resumes:
> 
>   # ynl --family rt-neigh --dump getneightbl --output-json |
>     jq '.[] | {name: .name, ifindex: .parms.ifindex}'
>   ...
>   {
>     "name": "ndisc_cache",
>     "ifindex": null
>   }
>   ...
>   {
>     "name": "ndisc_cache",
>     "ifindex": 6
>   }
>   {
>     "name": "ndisc_cache",
>     "ifindex": null
>   }
>   {
>     "name": "ndisc_cache",
>     "ifindex": 5
>   }
> 
> Let's skip neightbl_fill_info() if it is already called in
> neightbl_dump_info().
> 
> Note that we cannot use !neigh_skip instead of !default_skip
> because default_skip == 1 && neigh_skip == 0 could be true
> if the first neightbl_fill_param_info() fails.
> 
> Fixes: c7fb64db001f ("[NETLINK]: Neighbour table configuration and statistics via rtnetlink")
> Signed-off-by: Kuniyuki Iwashima <kuniyu@google.com>

Reviewed-by: Ido Schimmel <idosch@nvidia.com>