From: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
Subject: [PATCH v3 04/13] drm/xe/mmio: Report BAR mapping errors using structured xe_log API
Date: Tue, 8 Sep 2026 16:15:41 +0530 [thread overview]
Message-ID: <20260908104550.1283933-5-dnyaneshwar.bhadane@intel.com> (raw)
In-Reply-To: <20260908104550.1283933-1-dnyaneshwar.bhadane@intel.com>
Replace xe_err() calls with xe_log_err() and xe_log_err_fatal() using
the REGS component tag for MMIO BAR probe failures
Signed-off-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
---
drivers/gpu/drm/xe/xe_mmio.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_mmio.c b/drivers/gpu/drm/xe/xe_mmio.c
index 7fa18dfcb5a2..890146b8836b 100644
--- a/drivers/gpu/drm/xe/xe_mmio.c
+++ b/drivers/gpu/drm/xe/xe_mmio.c
@@ -15,6 +15,7 @@
#include "regs/xe_bars.h"
#include "xe_device.h"
#include "xe_gt_sriov_vf.h"
+#include "xe_log.h"
#include "xe_printk.h"
#include "xe_sriov.h"
#include "xe_tile_printk.h"
@@ -71,8 +72,8 @@ int xe_mmio_probe_tiles(struct xe_device *xe)
return 0;
if (xe->mmio.size < xe->info.tile_count * tile_mmio_size) {
- xe_err(xe, "GTTMMADR_BAR is too small for %d tiles: %zu\n",
- xe->info.tile_count, xe->mmio.size);
+ xe_log_err_fatal(xe, REGS, -EIO, "GTTMMADR_BAR is too small for %d tiles: %zu\n",
+ xe->info.tile_count, xe->mmio.size);
return -EIO;
}
@@ -105,13 +106,16 @@ int xe_mmio_probe_early(struct xe_device *xe)
xe->mmio.regs = pcim_iomap(pdev, GTTMMADR_BAR, 0);
if (!xe->mmio.regs) {
- xe_err(xe, "Failed to map GTTMMADR_BAR\n");
+ xe_log_err_fatal(xe, REGS, -EIO,
+ "Failed to map GTTMMADR_BAR\n");
return -EIO;
}
xe->mmio.size = pci_resource_len(pdev, GTTMMADR_BAR);
if (xe->mmio.size < SZ_16M) {
- xe_err(xe, "GTTMMADR_BAR is too small: %zu\n", xe->mmio.size);
+ xe_log_err_fatal(xe, REGS, -EIO,
+ "GTTMMADR_BAR is too small: %zu\n",
+ xe->mmio.size);
return -EIO;
}
--
2.54.0
next prev parent reply other threads:[~2026-09-08 10:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 10:45 [PATCH v3 00/13] drm/xe: Convert IO_BUS errors to structured xe_log API Dnyaneshwar Bhadane
2026-09-08 10:45 ` [PATCH v3 01/13] drm/xe/log: Add VRAM, PAT, and HWMON DRIVER_HARDWARE components Dnyaneshwar Bhadane
2026-09-08 10:45 ` [PATCH v3 02/13] drm/xe/ggtt: Report GGTT errors using structured logging Dnyaneshwar Bhadane
2026-09-08 10:57 ` sashiko-bot
2026-09-08 10:45 ` [PATCH v3 03/13] drm/xe/hwmon: Report errors using structured xe_log API Dnyaneshwar Bhadane
2026-09-08 10:45 ` Dnyaneshwar Bhadane [this message]
2026-09-08 10:45 ` [PATCH v3 05/13] drm/xe/memirq: " Dnyaneshwar Bhadane
2026-09-08 10:51 ` sashiko-bot
2026-09-08 10:45 ` [PATCH v3 06/13] drm/xe/reg_whitelist: Report whitelist overflow " Dnyaneshwar Bhadane
2026-09-08 18:12 ` Michal Wajdeczko
2026-09-08 10:45 ` [PATCH v3 07/13] drm/xe/reg_sr: Report save-restore errors " Dnyaneshwar Bhadane
2026-09-08 18:33 ` Michal Wajdeczko
2026-09-08 10:45 ` [PATCH v3 08/13] drm/xe/pat: Return error from xe_pat_init_early() on unknown platform Dnyaneshwar Bhadane
2026-09-08 18:37 ` Michal Wajdeczko
2026-09-08 10:45 ` [PATCH v3 09/13] drm/xe/pat: Report missing PAT table using structured xe_log API Dnyaneshwar Bhadane
2026-09-08 10:45 ` [PATCH v3 10/13] drm/xe/pci: Report unknown GMDID versions " Dnyaneshwar Bhadane
2026-09-08 10:45 ` [PATCH v3 11/13] drm/xe/lmtt: Report invalidation errors " Dnyaneshwar Bhadane
2026-09-08 10:45 ` [PATCH v3 12/13] drm/xe/vram: Report tile vs device VRAM visibility errors Dnyaneshwar Bhadane
2026-09-08 10:45 ` [PATCH v3 13/13] drm/xe/vram: Report VRAM errors using structured xe_log API Dnyaneshwar Bhadane
2026-09-08 13:17 ` ✓ CI.KUnit: success for drm/xe: Convert IO_BUS errors to structured xe_log API (rev3) Patchwork
2026-09-08 14:21 ` ✓ Xe.CI.BAT: " Patchwork
2026-09-08 18:11 ` ✓ Xe.CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260908104550.1283933-5-dnyaneshwar.bhadane@intel.com \
--to=dnyaneshwar.bhadane@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.