Re: [PATCH v3 1/2] dt-bindings: spi: Add Realtek RTD1625 SPI support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit changelog claims that 'NOR' was added to the commit message and binding title, but this change is entirely missing from the patch.
--

commit 1c453ccadad25a38f1223703bbe011ebdccd7ab7
Author: Jyan Chou <jyanchou@realtek.com>

dt-bindings: spi: Add Realtek RTD1625 SPI support

This commit adds the device tree binding schema for the Realtek RTD1625 SPI
Flash Controller.

> dt-bindings: spi: Add Realtek RTD1625 SPI support

[ ... ]

> Changes in v3:
> - Add Conor's acked-by tag.
> - Add "NOR" in commit message and binding title.

[Severity: Medium]
The changelog states that "NOR" was added to the commit message and binding
title, but the commit subject remains "dt-bindings: spi: Add Realtek RTD1625
SPI support". Could this be an oversight where the intended change to the
commit message was missed?

> diff --git a/Documentation/devicetree/bindings/spi/realtek,rtd1625-nor.yaml b/Documentation/devicetree/bindings/spi/realtek,rtd1625-nor.yaml
> new file mode 100644
> index 0000000000000..b967fdac333f8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/realtek,rtd1625-nor.yaml
> @@ -0,0 +1,65 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/spi/realtek,rtd1625-nor.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Realtek RTD1625 SPI Flash Controller

[Severity: Medium]
Does this binding title also miss the word "NOR" that was promised in the
v3 changelog?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908111640.2032749-1-eleanor.lin@realtek.com?part=1