All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>
Cc: "Christian Borntraeger" <borntraeger@linux.ibm.com>,
	"Vasily Gorbik" <gor@linux.ibm.com>,
	linux-s390@vger.kernel.org, "Heiko Carstens" <hca@linux.ibm.com>,
	"Alexander Gordeev" <agordeev@linux.ibm.com>
Subject: Re: [PATCH v2 08/12] mm: enable MMU_GATHER_RCU_TABLE_FREE for sh-X2
Date: Tue, 08 Sep 2026 12:45:51 +0000	[thread overview]
Message-ID: <20260908124551.E4D831F00A3D@smtp.kernel.org> (raw)
In-Reply-To: <20260908-rcu-pagetable-freeing-v2-8-1f60b64e878e@kernel.org>

> Currently, non-x2 sh specifies CONFIG_MMU_GATHER_RCU_TABLE_FREE allowing
> RCU page table freeing.
> 
> sh-X2 is problematic because it utilises slab-allocated PMD page tables,
> and thus tlb_remove_ptdesc() cannot be used in these cases.
> 
> All other sh variants are fine as commit e3ecf7c7d082 ("mm: pgtable:
> convert some architectures to use tlb_remove_ptdesc()") already converted
> page table freeing to use tlb_remove_ptdesc(), which does so after an RCU
> grace period when CONFIG_MMU_GATHER_RCU_TABLE_FREE is specified.
> 
> Resolve this issue by firstly specifying CONFIG_HAVE_ARCH_TLB_REMOVE_TABLE
> for sh-X2, so the arch can provide its own __tlb_remove_table()
> implementation (called after the RCU grace period).
> 
> [ ... ]
> 
> This forms part of an overall effort to switch every architecture to this
> mode.
> 
> Signed-off-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908-rcu-pagetable-freeing-v2-0-1f60b64e878e@kernel.org?part=8


  reply	other threads:[~2026-09-08 12:45 UTC|newest]

Thread overview: 75+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-08 12:32 [PATCH v2 00/12] mm: make userland page table freeing RCU-safe Lorenzo Stoakes (ARM)
2026-09-08 12:32 ` Lorenzo Stoakes (ARM)
2026-09-08 12:32 ` Lorenzo Stoakes (ARM)
2026-09-08 12:32 ` [PATCH v2 01/12] mm/huge_memory: zap deposited page tables after an RCU grace period Lorenzo Stoakes (ARM)
2026-09-08 12:32   ` Lorenzo Stoakes (ARM)
2026-09-08 12:32   ` Lorenzo Stoakes (ARM)
2026-09-08 12:45   ` sashiko-bot
2026-09-08 12:32 ` [PATCH v2 02/12] mm: enable MMU_GATHER_RCU_TABLE_FREE for most 2-level architectures Lorenzo Stoakes (ARM)
2026-09-08 12:32   ` Lorenzo Stoakes (ARM)
2026-09-08 12:32   ` Lorenzo Stoakes (ARM)
2026-09-08 12:44   ` sashiko-bot
2026-09-08 12:32 ` [PATCH v2 03/12] mm: enable MMU_GATHER_RCU_TABLE_FREE for MMU riscv Lorenzo Stoakes (ARM)
2026-09-08 12:32   ` Lorenzo Stoakes (ARM)
2026-09-08 12:32   ` Lorenzo Stoakes (ARM)
2026-09-08 12:42   ` sashiko-bot
2026-09-08 12:32 ` [PATCH v2 04/12] mm: enable MMU_GATHER_RCU_TABLE_FREE for MMU arm Lorenzo Stoakes (ARM)
2026-09-08 12:32   ` Lorenzo Stoakes (ARM)
2026-09-08 12:32   ` Lorenzo Stoakes (ARM)
2026-09-08 12:44   ` sashiko-bot
2026-09-08 12:32 ` [PATCH v2 05/12] mm: enable MMU_GATHER_RCU_TABLE_FREE for arc, microblaze, xtensa Lorenzo Stoakes (ARM)
2026-09-08 12:32   ` Lorenzo Stoakes (ARM)
2026-09-08 12:32   ` Lorenzo Stoakes (ARM)
2026-09-08 12:44   ` sashiko-bot
2026-09-08 12:32 ` [PATCH v2 06/12] mm: enable MMU_GATHER_RCU_TABLE_FREE for sparc64 Lorenzo Stoakes (ARM)
2026-09-08 12:32   ` Lorenzo Stoakes (ARM)
2026-09-08 12:32   ` Lorenzo Stoakes (ARM)
2026-09-08 12:43   ` sashiko-bot
2026-09-08 12:32 ` [PATCH v2 07/12] mm: enable MMU_GATHER_RCU_TABLE_FREE for m68k-coldfire Lorenzo Stoakes (ARM)
2026-09-08 12:32   ` Lorenzo Stoakes (ARM)
2026-09-08 12:32   ` Lorenzo Stoakes (ARM)
2026-09-08 12:46   ` sashiko-bot
2026-09-08 12:32 ` [PATCH v2 08/12] mm: enable MMU_GATHER_RCU_TABLE_FREE for sh-X2 Lorenzo Stoakes (ARM)
2026-09-08 12:32   ` Lorenzo Stoakes (ARM)
2026-09-08 12:32   ` Lorenzo Stoakes (ARM)
2026-09-08 12:45   ` sashiko-bot [this message]
2026-09-08 12:32 ` [PATCH v2 09/12] mm: enable MMU_GATHER_RCU_TABLE_FREE for m68k-motorola Lorenzo Stoakes (ARM)
2026-09-08 12:32   ` Lorenzo Stoakes (ARM)
2026-09-08 12:32   ` Lorenzo Stoakes (ARM)
2026-09-08 12:45   ` sashiko-bot
2026-09-08 12:32 ` [PATCH v2 10/12] mm: enable MMU_GATHER_RCU_TABLE_FREE for sparc32 Lorenzo Stoakes (ARM)
2026-09-08 12:32   ` Lorenzo Stoakes (ARM)
2026-09-08 12:32   ` Lorenzo Stoakes (ARM)
2026-09-08 12:53   ` sashiko-bot
2026-09-08 12:32 ` [PATCH v2 11/12] mm: make userland page table freeing RCU-safe Lorenzo Stoakes (ARM)
2026-09-08 12:32   ` Lorenzo Stoakes (ARM)
2026-09-08 12:32   ` Lorenzo Stoakes (ARM)
2026-09-08 12:52   ` sashiko-bot
2026-09-09  9:15   ` Kiryl Shutsemau
2026-09-09  9:15     ` Kiryl Shutsemau
2026-09-09  9:15     ` Kiryl Shutsemau
2026-09-09 16:44     ` Lorenzo Stoakes (ARM)
2026-09-09 16:44       ` Lorenzo Stoakes (ARM)
2026-09-09 16:44       ` Lorenzo Stoakes (ARM)
2026-09-08 12:32 ` [PATCH v2 12/12] mm: change the contract for free_pgtables(), update docs Lorenzo Stoakes (ARM)
2026-09-08 12:32   ` Lorenzo Stoakes (ARM)
2026-09-08 12:32   ` Lorenzo Stoakes (ARM)
2026-09-08 12:50   ` sashiko-bot
2026-09-09  9:24   ` Kiryl Shutsemau
2026-09-09  9:24     ` Kiryl Shutsemau
2026-09-09  9:24     ` Kiryl Shutsemau
2026-09-09 16:42     ` Lorenzo Stoakes (ARM)
2026-09-09 16:42       ` Lorenzo Stoakes (ARM)
2026-09-09 16:42       ` Lorenzo Stoakes (ARM)
2026-09-08 21:15 ` [PATCH v2 00/12] mm: make userland page table freeing RCU-safe Andrew Morton
2026-09-08 21:15   ` Andrew Morton
2026-09-08 21:15   ` Andrew Morton
2026-09-09 11:24   ` Lorenzo Stoakes (ARM)
2026-09-09 11:24     ` Lorenzo Stoakes (ARM)
2026-09-09 11:24     ` Lorenzo Stoakes (ARM)
2026-09-09  9:26 ` Kiryl Shutsemau
2026-09-09  9:26   ` Kiryl Shutsemau
2026-09-09  9:26   ` Kiryl Shutsemau
2026-09-09 11:07   ` Lorenzo Stoakes (ARM)
2026-09-09 11:07     ` Lorenzo Stoakes (ARM)
2026-09-09 11:07     ` Lorenzo Stoakes (ARM)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260908124551.E4D831F00A3D@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=agordeev@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=linux-s390@vger.kernel.org \
    --cc=ljs@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.