All of lore.kernel.org
 help / color / mirror / Atom feed
From: Birk Skyum <birk.skyum@pm.me>
To: Anvesh Jain P <anvesh.p@oss.qualcomm.com>
Cc: sashiko-bot@kernel.org,
	"Sibi Sankar" <sibi.sankar@oss.qualcomm.com>,
	"Hans de Goede" <hansg@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
	"Guenter Roeck" <linux@roeck-us.net>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Shuah Khan" <skhan@linuxfoundation.org>,
	"Randy Dunlap" <rdunlap@infradead.org>,
	"Daniel J Blueman" <daniel@quora.org>,
	"Maya Matuszczyk" <maccraft123mc@gmail.com>,
	linux-arm-msm@vger.kernel.org,
	platform-driver-x86@vger.kernel.org, linux-hwmon@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2 1/2] platform: arm64: qcom-hamoa-ec: monitor Slim 7x legacy sensors
Date: Tue, 08 Sep 2026 14:36:59 +0000	[thread overview]
Message-ID: <20260908143650.30134-1-birk.skyum@pm.me> (raw)
In-Reply-To: <20260908140849.229ED1F00A3A@smtp.kernel.org>

Hi Anvesh,

Sashiko flagged the pre-existing SCI cleanup gap on the reference-board
probe path. I reproduced it in KUnit with simulated I2C and IRQ devices:
when the thermal-capability read fails, SCI remains enabled after the
driver core releases the interrupt.

I noticed you already proposed the devm_add_action_or_reset() conversion
and agreed to split it out after Konrad's review:
https://lkml.iu.edu/hypermail/linux/kernel/2607.3/10628.html

With that conversion applied locally, the failure-path and removal tests
pass. Is there a standalone version available to test? Happy to share the
reproducer if useful. I'll keep this separate from the Yoga sensor RFC.

For the other v2 findings, I've queued the named I2C initializers for the
next revision. Guenter left the driver split to me, and v2 already moved
the documentation out of Documentation/hwmon as requested.

Thanks,
Birk


  reply	other threads:[~2026-09-08 14:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-08 13:58 [RFC PATCH v2 0/2] Monitor Yoga Slim 7x EC sensors without taking over cooling Birk Skyum
2026-09-08 13:58 ` [RFC PATCH v2 1/2] platform: arm64: qcom-hamoa-ec: monitor Slim 7x legacy sensors Birk Skyum
2026-09-08 14:08   ` sashiko-bot
2026-09-08 14:36     ` Birk Skyum [this message]
2026-09-09  4:58       ` Anvesh Jain P
2026-09-15  9:28   ` Anvesh Jain P
2026-09-08 13:58 ` [RFC PATCH v2 2/2] platform: arm64: qcom-hamoa-ec: test sensor and variant handling Birk Skyum
2026-09-08 14:20   ` sashiko-bot
2026-09-15  9:23 ` [RFC PATCH v2 0/2] Monitor Yoga Slim 7x EC sensors without taking over cooling Anvesh Jain P
2026-09-15 14:17   ` Birk Skyum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260908143650.30134-1-birk.skyum@pm.me \
    --to=birk.skyum@pm.me \
    --cc=anvesh.p@oss.qualcomm.com \
    --cc=bryan.odonoghue@linaro.org \
    --cc=corbet@lwn.net \
    --cc=daniel@quora.org \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=maccraft123mc@gmail.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=sashiko-bot@kernel.org \
    --cc=sibi.sankar@oss.qualcomm.com \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.