From: cem@kernel.org
To: cem@kernel.org
Cc: hch@lst.de, djwong@kernel.org, linux-xfs@vger.kernel.org
Subject: [PATCH 2/3] xfs: enable xfs_trans_cancel() to report and error code
Date: Tue, 8 Sep 2026 16:54:15 +0200 [thread overview]
Message-ID: <20260908145422.232985-3-cem@kernel.org> (raw)
In-Reply-To: <20260908145422.232985-1-cem@kernel.org>
From: Carlos Maiolino <cem@kernel.org>
Once in a while it's useful to know exactly what kind of error caused a
transaction to be cancelled.
Enable xfs_trans_cancel() to receive an error code to be reported.
Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
---
fs/xfs/xfs_trans.c | 8 +++++---
fs/xfs/xfs_trans.h | 6 +++++-
2 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/fs/xfs/xfs_trans.c b/fs/xfs/xfs_trans.c
index 792a67a7ec28..5bbbb9226864 100644
--- a/fs/xfs/xfs_trans.c
+++ b/fs/xfs/xfs_trans.c
@@ -971,8 +971,9 @@ xfs_trans_commit(
* xfs_trans_commit().
*/
void
-xfs_trans_cancel(
- struct xfs_trans *tp)
+__xfs_trans_cancel(
+ struct xfs_trans *tp,
+ int error)
{
struct xfs_mount *mp = tp->t_mountp;
struct xlog *log = mp->m_log;
@@ -999,7 +1000,8 @@ xfs_trans_cancel(
* here.
*/
if (dirty && !xfs_is_shutdown(mp)) {
- XFS_ERROR_REPORT("xfs_trans_cancel", XFS_ERRLEVEL_LOW, 0, mp);
+ XFS_ERROR_REPORT("xfs_trans_cancel", XFS_ERRLEVEL_LOW,
+ error, mp);
xfs_force_shutdown(mp, SHUTDOWN_CORRUPT_INCORE);
}
#ifdef DEBUG
diff --git a/fs/xfs/xfs_trans.h b/fs/xfs/xfs_trans.h
index 2b366851e9a4..30135152d043 100644
--- a/fs/xfs/xfs_trans.h
+++ b/fs/xfs/xfs_trans.h
@@ -213,6 +213,11 @@ xfs_trans_read_buf(
flags, bpp, ops);
}
+void __xfs_trans_cancel(xfs_trans_t *, int);
+
+#define xfs_trans_cancel(tp) __xfs_trans_cancel(tp, 0)
+#define xfs_trans_cancel_error(tp, error) __xfs_trans_cancel(tp, error)
+
struct xfs_buf *xfs_trans_getsb(struct xfs_trans *);
struct xfs_buf *xfs_trans_getrtsb(struct xfs_trans *tp);
@@ -237,7 +242,6 @@ void xfs_trans_log_inode(xfs_trans_t *, struct xfs_inode *, uint);
int xfs_trans_commit(struct xfs_trans *);
int xfs_trans_roll(struct xfs_trans **);
int xfs_trans_roll_inode(struct xfs_trans **, struct xfs_inode *);
-void xfs_trans_cancel(xfs_trans_t *);
int xfs_trans_ail_init(struct xfs_mount *);
void xfs_trans_ail_destroy(struct xfs_mount *);
--
2.55.0
next prev parent reply other threads:[~2026-09-08 14:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 14:54 [PATCH 0/3] Enable xfs error reporting to print out error codes cem
2026-09-08 14:54 ` [PATCH 1/3] xfs: add xfs_error_report the ability to display an error code cem
2026-09-08 15:16 ` Darrick J. Wong
2026-09-10 9:24 ` Carlos Maiolino
2026-09-08 16:53 ` Eric Sandeen
2026-09-08 17:02 ` Darrick J. Wong
2026-09-08 20:40 ` Eric Sandeen
2026-09-10 9:33 ` Carlos Maiolino
2026-09-08 14:54 ` cem [this message]
2026-09-08 15:27 ` [PATCH 2/3] xfs: enable xfs_trans_cancel() to report and " Darrick J. Wong
2026-09-10 9:17 ` Carlos Maiolino
2026-09-08 14:54 ` [PATCH 3/3] xfs: make xfs_iomap_write_direct() report an error to xfs_trans_cancel cem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260908145422.232985-3-cem@kernel.org \
--to=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.