From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C27074FB9A3 for ; Tue, 8 Sep 2026 15:40:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788882053; cv=none; b=h0W+fRRxhY8P8ZbGHJlYEXNM7CaxlIx3UmM0ZU3P3UZr3pRACv2vpWwI030M5GaVwg8HWJIlGIVMINGc/czS0TjuI0lXqnl9jyDz2vjP6lEStn/e3ko/lrKmPEvhFVTcm/oC7PP0JAe86xEBJDc1xxaH9v8+EL+evk2iDdrrfpQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788882053; c=relaxed/simple; bh=xP+SGTJ0UeVr5NeGVk9ATENN9MhV2ZGSZKnihroPGgo=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=MUqE7t1YEZgVZquqbTiK+P+60ApMkMQd8/uljjRAak7G2zae+9yCFoeIQQLGGsTWAS/465v9dSHEntdzlfUC7wsXHqCumBOXkN7TgXGP9wzXf5uIPj57XW//7q5vd8G/rtavc1YUZUBnWD0be8GzvS3TJtKArtTvfUxxqkxtQRc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 665AF1F00A3D; Tue, 8 Sep 2026 15:40:50 +0000 (UTC) From: sashiko-bot@kernel.org Subject: Re: [PATCH net-next v4 06/10] net: pcs: xpcs: add ANRESTART support for SGMII link recovery Reply-To: sashiko-reviews@lists.linux.dev To: "Coia Prant" Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, vkoul@kernel.org, olteanv@gmail.com, robh@kernel.org, neil.armstrong@linaro.org, wsa+renesas@sang-engineering.com, conor+dt@kernel.org In-Reply-To: <20260907153713.2572547-8-coiaprant@gmail.com> References: <20260907153713.2572547-2-coiaprant@gmail.com> <20260907153713.2572547-8-coiaprant@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 08 Sep 2026 15:40:26 +0000 Message-Id: <20260908154050.665AF1F00A3D@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] Stale comment contradicts new ANRESTART behavior. -- commit 553a0aad47033d8800155c135475e03ebbeacf26 Author: Coia Prant net: pcs: xpcs: add ANRESTART support for SGMII link recovery This commit modifies the XPCS driver to trigger ANRESTART alongside ANENABLE to ensure auto-negotiation correctly restarts on link state changes for certain hardware. It applies this both when starting AN and when the link is down but AN completion is detected. > diff --git a/drivers/net/pcs/pcs-xpcs.c b/drivers/net/pcs/pcs-xpcs.c > index 0337e2bcc0125..50b9cdf94fdaa 100644 > --- a/drivers/net/pcs/pcs-xpcs.c > +++ b/drivers/net/pcs/pcs-xpcs.c > @@ -816,9 +816,14 @@ static int xpcs_config_aneg_c37_sgmii(struct dw_xpcs= *xpcs, [ ... ] > if (neg_mode =3D=3D PHYLINK_PCS_NEG_INBAND_ENABLED) > ret =3D xpcs_write(xpcs, MDIO_MMD_VEND2, MII_BMCR, > - mdio_ctrl | BMCR_ANENABLE); > + mdio_ctrl | BMCR_ANENABLE | BMCR_ANRESTART); [Severity: Low] Since this change explicitly triggers AN restart here, does the comment earlier in xpcs_config_aneg_c37_sgmii() need to be updated? The block comment at the top of the function currently states: /* For AN for C37 SGMII mode, the settings are :- [ ... ] * Note: Since it is MAC side SGMII, there is no need to set * SR_MII_AN_ADV. MAC side SGMII receives AN Tx Config from * PHY about the link state change after C28 AN is completed * between PHY and Link Partner. There is also no need to * trigger AN restart for MAC-side SGMII. */ =20 It seems the new code logic contradicts the last sentence of this comment. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260907153713.2572= 547-2-coiaprant@gmail.com?part=3D6 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E123C79F82 for ; Tue, 8 Sep 2026 15:40:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GLx7RwoCRGMja8bq3B3HDWP8x2MzLD1zz8uGjT/j26c=; b=E71EJ+YtCIuhTW T8CqWfKsa7fQXUekclhHZoeNwnS9z9NxJ0FHvPlGjykAnuL82iYsiO17wydvrV909cO2TgvYusUii 2P3aaiHqWNnAHDaEx12fon8G86B8fjueg2tU+BnMM3Ii/9qKBu8QPFF+eegeCLIwJDgiU2PBJsJWi Ttg+hSnvVl7oEF2j0qDND4OyOTyCwX6eCM/htVQNt3s6eNE54bIaiFKA0EvoXEKGIXAbuuzmJDAPy q7oxGy7gLhnA8ChzbSfwL1og3bFi46Wq5OBZeM1bxSzUqNNiKNp1rLv34xuFH3sYo4mI2Cj1sEuo4 Km+eFSrzvyRfUPJMkt8w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x3xwK-00000009WLv-3SVf; Tue, 08 Sep 2026 15:40:52 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x3xwJ-00000009WLo-3sad for linux-phy@lists.infradead.org; Tue, 08 Sep 2026 15:40:51 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 1C941601F7; Tue, 8 Sep 2026 15:40:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 665AF1F00A3D; Tue, 8 Sep 2026 15:40:50 +0000 (UTC) From: sashiko-bot@kernel.org Subject: Re: [PATCH net-next v4 06/10] net: pcs: xpcs: add ANRESTART support for SGMII link recovery To: "Coia Prant" Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, vkoul@kernel.org, olteanv@gmail.com, robh@kernel.org, neil.armstrong@linaro.org, wsa+renesas@sang-engineering.com, conor+dt@kernel.org In-Reply-To: <20260907153713.2572547-8-coiaprant@gmail.com> References: <20260907153713.2572547-2-coiaprant@gmail.com> <20260907153713.2572547-8-coiaprant@gmail.com> Date: Tue, 08 Sep 2026 15:40:26 +0000 Message-Id: <20260908154050.665AF1F00A3D@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0xvd10gU3RhbGUgY29tbWVudCBj b250cmFkaWN0cyBuZXcgQU5SRVNUQVJUIGJlaGF2aW9yLgotLQoKY29tbWl0IDU1M2EwYWFkNDcw MzNkODgwMDE1NWMxMzU0NzVlMDNlYmJlYWNmMjYKQXV0aG9yOiBDb2lhIFByYW50IDxjb2lhcHJh bnRAZ21haWwuY29tPgoKbmV0OiBwY3M6IHhwY3M6IGFkZCBBTlJFU1RBUlQgc3VwcG9ydCBmb3Ig U0dNSUkgbGluayByZWNvdmVyeQoKVGhpcyBjb21taXQgbW9kaWZpZXMgdGhlIFhQQ1MgZHJpdmVy IHRvIHRyaWdnZXIgQU5SRVNUQVJUIGFsb25nc2lkZSBBTkVOQUJMRQp0byBlbnN1cmUgYXV0by1u ZWdvdGlhdGlvbiBjb3JyZWN0bHkgcmVzdGFydHMgb24gbGluayBzdGF0ZSBjaGFuZ2VzIGZvcgpj ZXJ0YWluIGhhcmR3YXJlLiBJdCBhcHBsaWVzIHRoaXMgYm90aCB3aGVuIHN0YXJ0aW5nIEFOIGFu ZCB3aGVuIHRoZSBsaW5rCmlzIGRvd24gYnV0IEFOIGNvbXBsZXRpb24gaXMgZGV0ZWN0ZWQuCgo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL25ldC9wY3MvcGNzLXhwY3MuYyBiL2RyaXZlcnMvbmV0L3Bj cy9wY3MteHBjcy5jCj4gaW5kZXggMDMzN2UyYmNjMDEyNS4uNTBiOWNkZjk0ZmRhYSAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL25ldC9wY3MvcGNzLXhwY3MuYwo+ICsrKyBiL2RyaXZlcnMvbmV0L3Bj cy9wY3MteHBjcy5jCj4gQEAgLTgxNiw5ICs4MTYsMTQgQEAgc3RhdGljIGludCB4cGNzX2NvbmZp Z19hbmVnX2MzN19zZ21paShzdHJ1Y3QgZHdfeHBjcyAqeHBjcywKWyAuLi4gXQo+ICAJaWYgKG5l Z19tb2RlID09IFBIWUxJTktfUENTX05FR19JTkJBTkRfRU5BQkxFRCkKPiAgCQlyZXQgPSB4cGNz X3dyaXRlKHhwY3MsIE1ESU9fTU1EX1ZFTkQyLCBNSUlfQk1DUiwKPiAtCQkJCSBtZGlvX2N0cmwg fCBCTUNSX0FORU5BQkxFKTsKPiArCQkJCSBtZGlvX2N0cmwgfCBCTUNSX0FORU5BQkxFIHwgQk1D Ul9BTlJFU1RBUlQpOwoKW1NldmVyaXR5OiBMb3ddClNpbmNlIHRoaXMgY2hhbmdlIGV4cGxpY2l0 bHkgdHJpZ2dlcnMgQU4gcmVzdGFydCBoZXJlLCBkb2VzIHRoZSBjb21tZW50CmVhcmxpZXIgaW4g eHBjc19jb25maWdfYW5lZ19jMzdfc2dtaWkoKSBuZWVkIHRvIGJlIHVwZGF0ZWQ/CgpUaGUgYmxv Y2sgY29tbWVudCBhdCB0aGUgdG9wIG9mIHRoZSBmdW5jdGlvbiBjdXJyZW50bHkgc3RhdGVzOgoK ICAgICAgICAvKiBGb3IgQU4gZm9yIEMzNyBTR01JSSBtb2RlLCB0aGUgc2V0dGluZ3MgYXJlIDot ClsgLi4uIF0KICAgICAgICAgKiBOb3RlOiBTaW5jZSBpdCBpcyBNQUMgc2lkZSBTR01JSSwgdGhl cmUgaXMgbm8gbmVlZCB0byBzZXQKICAgICAgICAgKiAgICAgICBTUl9NSUlfQU5fQURWLiBNQUMg c2lkZSBTR01JSSByZWNlaXZlcyBBTiBUeCBDb25maWcgZnJvbQogICAgICAgICAqICAgICAgIFBI WSBhYm91dCB0aGUgbGluayBzdGF0ZSBjaGFuZ2UgYWZ0ZXIgQzI4IEFOIGlzIGNvbXBsZXRlZAog ICAgICAgICAqICAgICAgIGJldHdlZW4gUEhZIGFuZCBMaW5rIFBhcnRuZXIuIFRoZXJlIGlzIGFs c28gbm8gbmVlZCB0bwogICAgICAgICAqICAgICAgIHRyaWdnZXIgQU4gcmVzdGFydCBmb3IgTUFD LXNpZGUgU0dNSUkuCiAgICAgICAgICovCiAgICAgICAgIApJdCBzZWVtcyB0aGUgbmV3IGNvZGUg bG9naWMgY29udHJhZGljdHMgdGhlIGxhc3Qgc2VudGVuY2Ugb2YgdGhpcyBjb21tZW50LgoKLS0g ClNhc2hpa28gQUkgcmV2aWV3IMK3IGh0dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRjaHNldC8yMDI2 MDkwNzE1MzcxMy4yNTcyNTQ3LTItY29pYXByYW50QGdtYWlsLmNvbT9wYXJ0PTYKCi0tIApsaW51 eC1waHkgbWFpbGluZyBsaXN0CmxpbnV4LXBoeUBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHBzOi8v bGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXBoeQo=