From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr2-f12.google.com (mail-wr2-f12.google.com [74.125.225.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62DAA367F2F for ; Tue, 8 Sep 2026 16:30:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.76 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788885004; cv=none; b=jBrnzwjOB3sD4QARJNMU//3ackrHW9nb1YBili0lSW3tt0Ijlo5n1cpJXkNq/mco+zsYleGPgTaM4nBslc8agqijNwzyBxdhIdG2zT/IOGyDRWPVwe3nL1tENCnIKyjRJbqHpODcP5OrrIzH6DtyWVWb8be5qR0i6QPewuQYoY0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788885004; c=relaxed/simple; bh=zyhhR75FYsJ7CI8Lb1oLs548FMMbMQZmnJj+IN0E3nc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IIf0AkP63a7PL81exv0+PZYbUHD/qUIiMcuhUdMmVUo7M27vPEFDDTw/FKCurr6tgj+M6IQL7FJyG0+XRLol5hOXSEqJdMHpP0MO/aApBDdxrfbu/kee1px6wixjhvM8UCH5cY55w6d16VxzpA3OqhXT8MTEkpm2X9gCc8Tj3VU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ALkwWEC0; arc=none smtp.client-ip=74.125.225.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ALkwWEC0" Received: by mail-wr2-f12.google.com with SMTP id ffacd0b85a97d-4843703c170so338862f8f.2 for ; Tue, 08 Sep 2026 09:30:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788885000; x=1789489800; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=emj4cn58BmwUvuEYrkn19RQf/kNhJ8y8Fx3ptxT/4jw=; b=ALkwWEC0tzySsfZX5cggYjdv/Pwnq8PxitOdGQh27zdjZ+l2ycmRfUDMIMQfP/RuK1 ASOQwwLitMWG6CcR1bjxRDoLyz9MtfsLuJha8SCUIcQmOofUM7HYtHLJGNHK4vKtcnCZ OFtKvaldRz0XykL/z6UZ7CNIEpIUiYPht8ivNrVrl9EXPeAJTp7FX5yDSDFKPfPdN9nD j1S1e7WLqfuJYVZ1bq9ENh5sxwh4bcgMklKv7Higral+0bZM/+r153Ojk2e4CHt16bi5 jujUsz3ChMO7jBnVryqbm2tTv2V00gNGN49E40SvV6EuhjY84Qjzya8w1UqjKTwSulfv Dplg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788885000; x=1789489800; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=emj4cn58BmwUvuEYrkn19RQf/kNhJ8y8Fx3ptxT/4jw=; b=kbB/uxRNzEAqdjHLRgE5kH3d52EWNwJCTVdBrbynZo69t6iW3Cih4Ym3YWXI6y/uaG x+hNq7bvf8f/ci1DP3nPqK0IncobDvDgjHOTO08c8G+J68nlm56TlEWH5nvmJkom9WR+ 8QECERlQz5F5i/Sfut6UcCOprPmoHhs4MtAgPPasM/5+0kCW06+VxppkK8R649VMaK7t ujrXA0Sk0fzMPrai1xQcUM+OSuCNissNZ5CSJD52/y1vtW7qJ5C+IY8VP6Ur27uqUC9N 7LYKX4B1BRPIXeCpEWWi2VbXa62zXrt0Y8mcpqdLu6zwRebAsvpt3nlWu2Q0XFlD1MND sXHQ== X-Forwarded-Encrypted: i=1; AKwUvBwHmAKPVdnwNHLhLW+0JgPPnrB6WjJvHre0JGh8DdfHJ82uoN71GwfICuGtYC7c4UWjziI6o2J4uRFhQEU=@vger.kernel.org X-Gm-Message-State: AFuF++lRovYIOfGQS6nKsV53stmR8WAddNX9QyKQ5L3wm/4XuoqcZOnB V5uf//S4UHh8lK5tdHO5GfQBLQptsPsUpBsFMkX6pXbe4cgFxX0H0KSv8GscWu+H X-Gm-Gg: AYBFou07zbVHp3BhBkJ9R72bKQ4HA9vlM5y+Cuxcr1T1Vz6Tb02PEw99QHW2m8tD/Fm IojyF+L3lfTkr2WFpLKaAC2j0fZbf6FQGpQMmF55iJOBqeET+WWb0xATuJJfSm0bAtYwmzH3Isk XEYsFwdgtGwMeBTee3E/9qW3GbgSBkNdTkFfcktnTIQswycEr8rN8blzlcd8dS/WSWEMp82Yvbw PK43RgmzrjLQoUNDsmS+vYkxke7W11c5nNWDiGgKuFikvPHScBCdgvI031N2EfUsTjLOXMMPhX3 AIRLb1j4RPeUR0/Abr0PtJgU9WFPl6OwHlwGiVo0fIDiQifSlvSFC9yGzv5BP18tyGdM7JUEAhM 7F9HyeFOxKbXdMW5u4yJGLW5UXcfRNh6aU2kCl06c3vEB6tjnSjNLylT/T0HlmU5TG1zuLjiiQ+ PJz8uP23uus3+FTPOw6BCgPqhUq1uFK2GTs8FOJLNRmCwBpgQKfPeLb3oMbLBaxsy3zCzGpqeG/ qyTPh4X7/9fqXYk6OsCy0FngnYiuXuoE0LiOAk02DSJ/oELt1Cc8qGt/j/mn1euAGl6 X-Received: by 2002:a05:600c:c494:b0:499:d95a:41f with SMTP id 5b1f17b1804b1-49d010c3969mr205691045e9.0.1788884999944; Tue, 08 Sep 2026 09:29:59 -0700 (PDT) Received: from OrangePi5-Plus.BB-HOME (20014C4E1B825D00814606522702B594.dsl.pool.telekom.hu. [2001:4c4e:1b82:5d00:8146:652:2702:b594]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49d00031c95sm378593345e9.11.2026.09.08.09.29.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 09:29:59 -0700 (PDT) From: Igor Paunovic To: Sebastian Reichel , Vinod Koul , Neil Armstrong , Manivannan Sadhasivam , Heiko Stuebner , Maxime Chevallier Cc: Igor Paunovic , linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCH] phy: rockchip: inno-usb2: ensure PHY is running when clock is requested Date: Tue, 8 Sep 2026 18:29:28 +0200 Message-ID: <20260908162935.7092-1-royalnet026@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260908-phy-rockchip-inno-usb2-clock-fix-v1-1-f7d59c31b908@collabora.com> References: <20260908-phy-rockchip-inno-usb2-clock-fix-v1-1-f7d59c31b908@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Sebastian, Tested-by: Igor Paunovic # Orange Pi 5 Plus (RK3588) Repeating the tag here so it is picked up with the patch: I tested this in your rockchip-devel branch earlier today and reported the details in [1], but that was in my own bug report thread rather than under the patch. The code you posted is identical to what I tested, only the base differs. Briefly: 4 full s2idle cycles with all four USB 2.0 hosts bound, which hung every time before and needed a cold reset. The OHCI whose 480 MHz clock had it as its only user went from "enters ohci_platform_resume and never returns" to returning 0 after ~20.7 ms, 8 out of 8 resume passes. One data point for the reviewers here, since it concerns the guard at the top of the new function: if (rphy->phy_cfg->num_ports > 1) return 0; All four entries in rk3588_phy_cfgs[] have num_ports = 1 (0x0000 and 0x4000 as OTG, 0x8000 and 0xc000 as HOST), so the new code does run on RK3588, including u2phy2 at 0x8000 whose controller is the one that hung for me. The num_ports = 2 configs are the older SoCs, so the guard costs RK3588 nothing. [1] https://lore.kernel.org/all/20260908144245.10700-1-royalnet026@gmail.com/ Igor From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB997C79F9E for ; Tue, 8 Sep 2026 16:30:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tXYOV3Qvo49sz/YnI/fehAO9QiaXQmW9R8fDQTkoazs=; b=0S2LXC+6kL8X/h 5nwnGvMVI+mfvjC2t62XyLpRc8kCgrnArXq3rHCw1EJVUi9TgeCERlfoYYufMKm5+HxgpCPvtOEyq 3NyKJV+e7Iu41VA9IZsUlwBiU2sfBk34U/67mk5YeEEougyb/ivx+QbEHXCkoLZ6HBEinvb1dbCkz Uanpyj61mzy4IaHoC4wUxDYgq/y/P8gkNJst1D1l9trOB95CHBCYbw/Zo5Q3NxEMbmY5V+5ARx55o aadom8Ry0IJzuCYd22J+gI2xZntk2fE/kyzJQgRgEVdpsget9I/6yv/hhqWAr3a2Z02/OWS3VgvWR ZG1s+3Q7kM7FawYZKWnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x3yhz-00000009fwl-0beg; Tue, 08 Sep 2026 16:30:07 +0000 Received: from mail-wr2-x10.google.com ([2a00:1450:4864:30::10]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x3yhu-00000009fuq-0bzL for linux-rockchip@lists.infradead.org; Tue, 08 Sep 2026 16:30:03 +0000 Received: by mail-wr2-x10.google.com with SMTP id ffacd0b85a97d-4843178b1c8so404279f8f.0 for ; Tue, 08 Sep 2026 09:30:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788885000; x=1789489800; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=emj4cn58BmwUvuEYrkn19RQf/kNhJ8y8Fx3ptxT/4jw=; b=kMz5/dAbNReDV0kMUYi5T3IadeI6vBqN8QmtpUD54Ds3ZC+NlrUDL/qmsl4ZEsrKmM rlwhA6KIcLWmKxx3U5SaiY/mojTlJShP1LdNZx+jkzslpfgNRLwmG6AjMuXFsyzlHFc3 Lvz6Dw/OtFr7iVAmMEyDx8gQqESiG1wT6GDKzne6ZYBCLgr9FOoWXxKz6rNJdXw+K2+c 0e5sfJwh9fmevJFTb65j3UI7J5yBUZX6g5DVqJDDN0EY1o/ktA6lvP7/ydKenPzZJmIl HOD/7UXpupl/otXFMqSCLwAIhmXSMblkqbH6V1pOikVx5WIj+Og77tpJuV3XqBIUbvsy Me7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788885000; x=1789489800; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=emj4cn58BmwUvuEYrkn19RQf/kNhJ8y8Fx3ptxT/4jw=; b=W5Vp82Tk5U8Ngm06g/leXFyMP5+ZwFsaUNWgoohyttr00tWgRK9OlCk6jd1ii4Usxf CCYHlCkSlnUZuC+6lN8C6DH4hSMpr43xL2JZVcgsRBsDZD6j7q/PhwNajLCv55jMBrl/ 00DH3jxdQQk8SpvTb6maDQIGTlVWho+SKe+K7ZBr004A5is67AFN+ROc8QrPgQAKaZ7H ZvHFspxa9UylDA8kLWwf5zhsfY5OYHS7UwNT0EomBqNHGJmAE/l5ZDuc7s6/pNWRs/tn aBe8bngxUsYNYR1o0iRUMvGE9OT7nYWMF6CX8bCPaOjthRZk8IyxWEz6TOgIGffbmeX5 ac0Q== X-Forwarded-Encrypted: i=1; AKwUvBxbrMCGrUGG3YTIPkwkWSSTcpWBfEOS62R9ww5e4J40iuzGy+93iiWAEpKwXTIRb/E6RGS40Yo2BrDvh+giug==@lists.infradead.org X-Gm-Message-State: AFuF++nUISN0ch0uK3c9TVTSOjhlck/Tnkf8xOen3/uta18cxf7XggT9 io2Hb61PeOMeHY5jNQ6Cy23OSGRZfgWK48tEzG1IwXeeM3GFD3L/z27f X-Gm-Gg: AYBFou33S8vBGtl1kv/wmt2kSuTMupX2KDPOrHJRkkvu+rbUTJoPyxeT8V7sglEt6E+ R2yUtGtTRjL8pEZuwrzOkiPtf4F9s8LfDiKfDHvy4XppxDcw6QltkJIXRMrbwlL3A+oiIo/ODGY aH6sK1cNEU8Oi9B1DMr4xkeu8z85UzI6pcrPJZgQ9Hu55ae/U5mOgFY1Y1xWDfs/GbD7VUNI3Tu AMXywQmcHcvAQi9co6DI2qWrB09MnLsFUQzaJKBk6p2oh0BswZaxKE46lSaiHgengKeuLHlpZLg q7xwxgyWLCacPRAXX78ZDICbAuiAE9qKqdTCHnNiOIJNJnlDE6w2poSwb/LQs3lwxqKUBLZyR4b /7wwWAGiUosVZWefS/1DCbwSt1v/DkQ9rLQ7xgK2OX9PktHLP3IrAUrjHKMCWszmNqA/nczAypx c2uwtzvDTTllejwiVAuje0HLqeKKbVHpb6BkQMMbANRtSMl/yyzBdTttcTAtf/y1Q2s3EZYyCiP E4fYAnKYJsWKHltWwO0DVvowXAjFf372T5LYy3ajIegiiNwj9DnnCPK0bBLh/N6JR5c X-Received: by 2002:a05:600c:c494:b0:499:d95a:41f with SMTP id 5b1f17b1804b1-49d010c3969mr205691045e9.0.1788884999944; Tue, 08 Sep 2026 09:29:59 -0700 (PDT) Received: from OrangePi5-Plus.BB-HOME (20014C4E1B825D00814606522702B594.dsl.pool.telekom.hu. [2001:4c4e:1b82:5d00:8146:652:2702:b594]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49d00031c95sm378593345e9.11.2026.09.08.09.29.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 09:29:59 -0700 (PDT) From: Igor Paunovic To: Sebastian Reichel , Vinod Koul , Neil Armstrong , Manivannan Sadhasivam , Heiko Stuebner , Maxime Chevallier Cc: Igor Paunovic , linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCH] phy: rockchip: inno-usb2: ensure PHY is running when clock is requested Date: Tue, 8 Sep 2026 18:29:28 +0200 Message-ID: <20260908162935.7092-1-royalnet026@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260908-phy-rockchip-inno-usb2-clock-fix-v1-1-f7d59c31b908@collabora.com> References: <20260908-phy-rockchip-inno-usb2-clock-fix-v1-1-f7d59c31b908@collabora.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260908_093002_201467_737AEF01 X-CRM114-Status: GOOD ( 12.48 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hi Sebastian, Tested-by: Igor Paunovic # Orange Pi 5 Plus (RK3588) Repeating the tag here so it is picked up with the patch: I tested this in your rockchip-devel branch earlier today and reported the details in [1], but that was in my own bug report thread rather than under the patch. The code you posted is identical to what I tested, only the base differs. Briefly: 4 full s2idle cycles with all four USB 2.0 hosts bound, which hung every time before and needed a cold reset. The OHCI whose 480 MHz clock had it as its only user went from "enters ohci_platform_resume and never returns" to returning 0 after ~20.7 ms, 8 out of 8 resume passes. One data point for the reviewers here, since it concerns the guard at the top of the new function: if (rphy->phy_cfg->num_ports > 1) return 0; All four entries in rk3588_phy_cfgs[] have num_ports = 1 (0x0000 and 0x4000 as OTG, 0x8000 and 0xc000 as HOST), so the new code does run on RK3588, including u2phy2 at 0x8000 whose controller is the one that hung for me. The num_ports = 2 configs are the older SoCs, so the guard costs RK3588 nothing. [1] https://lore.kernel.org/all/20260908144245.10700-1-royalnet026@gmail.com/ Igor _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0866DC79F99 for ; Tue, 8 Sep 2026 16:30:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GchitPZ1G+7yGLQaJeRHBF070GkW4b0+u9NJ2kxokE8=; b=2JpUmW3SbXDDyU A73L9+8Fs8irmeE2kb1n/xO4B7av8o9/NUi1uqP90TsfWJt/4mbpUYO+GomipcoWt5t0SPUSUor8M GnptJfewvoCrK4wdCzr+DlD/qL3EIpGgjJbJ2BNO8bPVJIJfxwu8nyX4rbXhnSgxeq5DiO6sRCx3g 65zSobpCVAVo9JgnYpRvDg5BRoi0Lu6cdFVXuCx8meVGQwDs/eZXm+9hkpogqAA2DRW2l6kQ2U1Ay O4VLOq17q1kn53aL6OqZfcbbt8Wj2RBeu/7X8KhZQl2i7JE8j1xZq73aa+1MAtRj6e3lIfrLViRr9 gou5sUgpE5ggByNe5SYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x3yhz-00000009fyq-2xYT; Tue, 08 Sep 2026 16:30:07 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x3yhx-00000009fwq-2oIF for linux-phy@bombadil.infradead.org; Tue, 08 Sep 2026 16:30:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=emj4cn58BmwUvuEYrkn19RQf/kNhJ8y8Fx3ptxT/4jw=; b=aLrVrxp2WFNH1GpesDrxih8HDL f4UgdE6yvgVHxnWhDkhT3erkIK7cGXJKvmfBVs1Tu0QycTGKtoVrLYzvJE7nFYz+Px+Y5gDmxAcsk 3U3IN1Q9aIKcoB6spi7tfMZom+GX4llzmExOpFWWyeSMEzkOCS7appT28gW0Yllk/SMfQizfT6Zwc 11xSwZGSFuQnS2PGOp0pk2uzI1cMJmas33DYS5IovbtEcZRN7izQezfqdxxwoeGha+tciULct20qM wIJkhrpYWgRQlL8HyclLTIbx3igBWxj3kfszovQA+StgJD1y/yoJqdBNe7NrdKCpboErKub/TeJu7 E5YuhC1w==; Received: from mail-wr2-x10.google.com ([2a00:1450:4864:30::10]) by desiato.infradead.org with esmtps (Exim 4.99.2 #2 (Red Hat Linux)) id 1x3yhu-000000005pJ-04eL for linux-phy@lists.infradead.org; Tue, 08 Sep 2026 16:30:04 +0000 Received: by mail-wr2-x10.google.com with SMTP id ffacd0b85a97d-482e1b30c94so313171f8f.1 for ; Tue, 08 Sep 2026 09:30:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788885000; x=1789489800; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=emj4cn58BmwUvuEYrkn19RQf/kNhJ8y8Fx3ptxT/4jw=; b=kMz5/dAbNReDV0kMUYi5T3IadeI6vBqN8QmtpUD54Ds3ZC+NlrUDL/qmsl4ZEsrKmM rlwhA6KIcLWmKxx3U5SaiY/mojTlJShP1LdNZx+jkzslpfgNRLwmG6AjMuXFsyzlHFc3 Lvz6Dw/OtFr7iVAmMEyDx8gQqESiG1wT6GDKzne6ZYBCLgr9FOoWXxKz6rNJdXw+K2+c 0e5sfJwh9fmevJFTb65j3UI7J5yBUZX6g5DVqJDDN0EY1o/ktA6lvP7/ydKenPzZJmIl HOD/7UXpupl/otXFMqSCLwAIhmXSMblkqbH6V1pOikVx5WIj+Og77tpJuV3XqBIUbvsy Me7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788885000; x=1789489800; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=emj4cn58BmwUvuEYrkn19RQf/kNhJ8y8Fx3ptxT/4jw=; b=Wj9lrqwi835qAelKw71CBroBx8DEhUx3E4GmU+oteMLBKoq9tj11z21PmHJTchCOCA AtpHWa4tARSSkSzpYOHyi8KO0t83+DOcSsGJMYhvihl22tGmyMnKRB2DWib03vGXu5dD EqT3mCUyeeVVWVDivdpg3mRY9v9uk6RlsH3cSivKNxM+GgzFLGMR5aifQMI9O6L2u9VA /NGcSxUZ3lDwqGcrbjALrbsYnmUtQyRjxZAsW8wevRoIh35H/WQSccfYHgQEGMvuLTkp u/JnzdY8fEgV257WGlrnZb0lRDkCeNyezQWFgF+WVcLoH1J9riPmYZSYgpj0UZT0afo0 3olQ== X-Forwarded-Encrypted: i=1; AKwUvBxlfnUto0k/r8CMjXU0pXpOgzymbvRgiYlz1cjCGdmC3e60pjT80IBnrx8OjhnguzH3RPeiRD1e9Qk=@lists.infradead.org X-Gm-Message-State: AFuF++kO8LBtz5nNy9LCObpn2UjoiMQkOB7ozIvL09cWbYXQF6E+E1Ra TP/MK+I07ftnV45DFjA/qVnbj9T+hEXppCySHrHd0+s53lOmsGNfY8uD X-Gm-Gg: AYBFou06vV/6gh1MAmtK0t+JJn/eUEtluqI9JeU3SNthga5+VG9CCEw1ngb0gDJtbqk 4jjHY5bwJ87bhmLeAwT66qtzBSde7yaPgq2oVCbW5ES94VY/d+hYwcud+tU5EJWgosrO62IfmOF s/SRmldZWMQvwA2Lq5gOuvr1jLfEZJAlXDLYWeGSOUZs+ryC3Nk5k4p+Mhxeq7tynf642PABJto 8rDs0OO8520FkbwFDdt1OXUP35IdRA6u8/+o/DdiZWTsbC/v9RXuUROOgQ+gg1aONDi5IyGFJ6n 8zsSLlrgiCRC+X8Nh0jT3kBi15cjkjbwZU1/PCCQDSPHTRKdTTlyXqH5Bf2KNNXy7ErFm1WHEMd KZTDfg0jZucMsVHP3fIVrq8bPyAQaaKCpBmcjJx+E1xXkjXF7y73dBwA8NIfMobLnr2sD00ruYk Qc6UvePTfvWWSvh2+C1X5n66ix7Rl/+am6H/dLnKjhRLWwf7I1lXr+1R5fA7CBQNXmjmvv0hF6L GrvQPahkAFbOxfDH9ddyjPbd/QAB53M8fCBEflkMXHrMfZpD3QpRxKAOznSx+933+00 X-Received: by 2002:a05:600c:c494:b0:499:d95a:41f with SMTP id 5b1f17b1804b1-49d010c3969mr205691045e9.0.1788884999944; Tue, 08 Sep 2026 09:29:59 -0700 (PDT) Received: from OrangePi5-Plus.BB-HOME (20014C4E1B825D00814606522702B594.dsl.pool.telekom.hu. [2001:4c4e:1b82:5d00:8146:652:2702:b594]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49d00031c95sm378593345e9.11.2026.09.08.09.29.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 09:29:59 -0700 (PDT) From: Igor Paunovic To: Sebastian Reichel , Vinod Koul , Neil Armstrong , Manivannan Sadhasivam , Heiko Stuebner , Maxime Chevallier Cc: Igor Paunovic , linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCH] phy: rockchip: inno-usb2: ensure PHY is running when clock is requested Date: Tue, 8 Sep 2026 18:29:28 +0200 Message-ID: <20260908162935.7092-1-royalnet026@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260908-phy-rockchip-inno-usb2-clock-fix-v1-1-f7d59c31b908@collabora.com> References: <20260908-phy-rockchip-inno-usb2-clock-fix-v1-1-f7d59c31b908@collabora.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260908_173002_139944_64D98883 X-CRM114-Status: GOOD ( 12.21 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Hi Sebastian, Tested-by: Igor Paunovic # Orange Pi 5 Plus (RK3588) Repeating the tag here so it is picked up with the patch: I tested this in your rockchip-devel branch earlier today and reported the details in [1], but that was in my own bug report thread rather than under the patch. The code you posted is identical to what I tested, only the base differs. Briefly: 4 full s2idle cycles with all four USB 2.0 hosts bound, which hung every time before and needed a cold reset. The OHCI whose 480 MHz clock had it as its only user went from "enters ohci_platform_resume and never returns" to returning 0 after ~20.7 ms, 8 out of 8 resume passes. One data point for the reviewers here, since it concerns the guard at the top of the new function: if (rphy->phy_cfg->num_ports > 1) return 0; All four entries in rk3588_phy_cfgs[] have num_ports = 1 (0x0000 and 0x4000 as OTG, 0x8000 and 0xc000 as HOST), so the new code does run on RK3588, including u2phy2 at 0x8000 whose controller is the one that hung for me. The num_ports = 2 configs are the older SoCs, so the guard costs RK3588 nothing. [1] https://lore.kernel.org/all/20260908144245.10700-1-royalnet026@gmail.com/ Igor -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy