From: Joshua Crofts <joshua.crofts1@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Andy Shevchenko" <andy.shevchenko@gmail.com>,
"Kim Seer Paller" <kimseer.paller@analog.com>,
"Marilene Andrade Garcia" <marilene.agarcia@gmail.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] iio: adc: max14001: add missing MODULE_DEVICE_TABLE macro
Date: Tue, 8 Sep 2026 17:12:42 +0200 [thread overview]
Message-ID: <20260908171242.00007f88@gmail.com> (raw)
In-Reply-To: <aqAlAJEJPrglb2E_@ashevche-desk.local>
On Tue, 8 Sep 2026 18:08:48 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Tue, Sep 08, 2026 at 03:03:11PM +0200, Joshua Crofts wrote:
> > On Tue, 8 Sep 2026 15:41:23 +0300
> > Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> > > On Tue, Sep 8, 2026 at 2:41 PM Joshua Crofts <joshua.crofts1@gmail.com> wrote:
> > > >
> > > > The MAX14001 has an SPI ID table, but is missing a MODULE_DEVICE_TABLE()
> > > > macro.
> > >
> > > Is this a problem?
> >
> > For systems using devicetree, no. For legacy systems using spi_board_info and
> > this stuff, yes.
> >
> > If you're referring to the mark for stable then I'm fine with removing it.
>
> No, I'm trying to (implicitly) tell you that the commit message misses
> the answer to "why?".
>
Oh right... Will update in v2.
--
Kind regards,
Joshua Crofts
prev parent reply other threads:[~2026-09-08 15:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 11:40 [PATCH] iio: adc: max14001: add missing MODULE_DEVICE_TABLE macro Joshua Crofts
2026-09-08 12:41 ` Andy Shevchenko
2026-09-08 13:03 ` Joshua Crofts
2026-09-08 15:08 ` Andy Shevchenko
2026-09-08 15:12 ` Joshua Crofts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260908171242.00007f88@gmail.com \
--to=joshua.crofts1@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=kimseer.paller@analog.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marilene.agarcia@gmail.com \
--cc=nuno.sa@analog.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.