From: Minxi Hou <houminxi@gmail.com>
To: netdev@vger.kernel.org
Cc: aconole@redhat.com, echaudro@redhat.com, i.maximets@ovn.org,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org, shuah@kernel.org,
dev@openvswitch.org, linux-kselftest@vger.kernel.org,
Minxi Hou <houminxi@gmail.com>
Subject: [PATCH net-next v3 0/4] selftests: openvswitch: pylint cleanup of ovs-dpctl.py
Date: Tue, 8 Sep 2026 13:18:55 -0400 [thread overview]
Message-ID: <20260908171859.1967327-1-houminxi@gmail.com> (raw)
Hi,
This is a respin of the ovs-dpctl.py pylint cleanup series. The series
raises the pylint score of ovs-dpctl.py from 7.69 to 10.00. Each patch
targets one warning class and makes no behavior change.
v2 -> v3:
- Rewrote patch 3/4 (docstrings). In v2 many of the added docstrings
were shifted by one method and described the wrong operation (e.g.
OvsDatapath.create carried "Destroy a datapath."). Every docstring
is now derived from the method it documents.
- Dropped the ctact -> CtAct class rename and the parsed_len ->
parsedLen variable rename that had leaked into patches 2/4 and 3/4.
Class and variable names now stay as upstream has them; the
corresponding invalid-name warnings are covered by the module-level
disable in patch 4/4 instead.
- Moved three hunks to the patches they belong to: one f-string
conversion went to patch 1/4, the bare-except fix and the two
@staticmethod decorators went to patch 2/4 (the v2 patch 2/4
changelog claimed the except fix but the hunk itself sat in 3/4).
- Rebased onto ab217fbb9b21 ("Merge branch 'net-sysfs-use-ops-lock-
for-speed-and-duplex'") to resolve the pw-ci contest conflict.
v2: https://lore.kernel.org/netdev/20260905104026.3776396-1-houminxi@gmail.com/
v1: https://lore.kernel.org/netdev/20260513121240.2590767-1-houminxi@gmail.com/
Thanks,
Minxi
Signed-off-by: Minxi Hou <houminxi@gmail.com>
Minxi Hou (4):
selftests: openvswitch: convert %-formatting to f-strings
selftests: openvswitch: fix misc pylint warnings in ovs-dpctl.py
selftests: openvswitch: add missing docstrings in ovs-dpctl.py
selftests: openvswitch: suppress pylint complexity warnings
.../selftests/net/openvswitch/ovs-dpctl.py | 408 ++++++++++--------
1 file changed, 236 insertions(+), 172 deletions(-)
base-commit: ab217fbb9b2169ce677b09a66558d5c3adcfbb76
--
2.55.0
next reply other threads:[~2026-09-08 17:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 17:18 Minxi Hou [this message]
2026-09-08 17:18 ` [PATCH net-next v3 1/4] selftests: openvswitch: convert %-formatting to f-strings Minxi Hou
2026-09-08 17:18 ` [PATCH net-next v3 2/4] selftests: openvswitch: fix misc pylint warnings in ovs-dpctl.py Minxi Hou
2026-09-08 17:18 ` [PATCH net-next v3 3/4] selftests: openvswitch: add missing docstrings " Minxi Hou
2026-09-10 17:22 ` netdev-bot+sashiko
2026-09-10 17:44 ` Aaron Conole
2026-09-08 17:18 ` [PATCH net-next v3 4/4] selftests: openvswitch: suppress pylint complexity warnings Minxi Hou
2026-09-10 17:22 ` netdev-bot+sashiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260908171859.1967327-1-houminxi@gmail.com \
--to=houminxi@gmail.com \
--cc=aconole@redhat.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=echaudro@redhat.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=i.maximets@ovn.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.