From: sashiko-bot@kernel.org
To: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>
Cc: dri-devel@lists.freedesktop.org,
linux-trace-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
linux-perf-users@vger.kernel.org, linux-scsi@vger.kernel.org,
"Vasily Gorbik" <gor@linux.ibm.com>,
bpf@vger.kernel.org, "Heiko Carstens" <hca@linux.ibm.com>,
selinux@vger.kernel.org,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Marc Zyngier" <maz@kernel.org>,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
kvm@vger.kernel.org, "Oliver Upton" <oupton@kernel.org>,
kvmarm@lists.linux.dev
Subject: Re: [PATCH 28/39] mm: drop some redundant checks around hugetlb VMAs
Date: Tue, 08 Sep 2026 20:39:59 +0000 [thread overview]
Message-ID: <20260908204000.670501F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260908-b4-mmap-prepare-vma-flag-sanify-v1-28-dacf19cce22b@kernel.org>
> Adjust code which inadvertently perform redundant checks on hugetlb VMAs
> and clean them up:
>
> * hugetlb VMAs have VMA_DONTEXPAND_BIT set so a VMA_SPECIAL_FLAGS check
> suffices. (migrate_vma_setup() regains an explicit hugetlb test later in
> the series, once VMA_SPECIAL_FLAGS is removed.)
>
> * hugetlb VMAs unconditionally set vma->vm_ops, so they are never
> anonymous.
>
> * hugetlb VMAs do not set VMA_PFNMAP_BIT so checking for this is redundant.
>
> While we're here also drop a VM_BUG_ON() which the simplified check above
> makes unreachable, and use the new VMA flag API.
>
> No functional change intended.
>
> Signed-off-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260908-b4-mmap-prepare-vma-flag-sanify-v1-0-dacf19cce22b@kernel.org?part=28
next prev parent reply other threads:[~2026-09-08 20:40 UTC|newest]
Thread overview: 144+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 20:01 [PATCH 00/39] mm: make VMA flag semantics explicit, eliminate VM_SPECIAL Lorenzo Stoakes (ARM)
2026-09-08 20:01 ` Lorenzo Stoakes (ARM)
2026-09-08 20:01 ` [PATCH 01/39] mm/vma: predicate setting mmap_prepare VMA fields on new vma alloc Lorenzo Stoakes (ARM)
2026-09-08 20:01 ` Lorenzo Stoakes (ARM)
2026-09-08 20:42 ` sashiko-bot
2026-09-08 20:01 ` [PATCH 02/39] mm/vma: introduce and use vma_[flags_]can_merge() Lorenzo Stoakes (ARM)
2026-09-08 20:01 ` Lorenzo Stoakes (ARM)
2026-09-08 20:27 ` sashiko-bot
2026-09-08 20:01 ` [PATCH 03/39] mm: consistently validate VMA state after mmap[_prepare] hooks Lorenzo Stoakes (ARM)
2026-09-08 20:01 ` Lorenzo Stoakes (ARM)
2026-09-08 20:40 ` sashiko-bot
2026-09-08 20:01 ` [PATCH 04/39] mm/vma: ensure mmap_prepare doesn't set actions on a mergeable vma Lorenzo Stoakes (ARM)
2026-09-08 20:01 ` Lorenzo Stoakes (ARM)
2026-09-08 20:36 ` sashiko-bot
2026-09-08 20:01 ` [PATCH 05/39] mm: make map_kernel_pages_[prepare,complete] internal and unexported Lorenzo Stoakes (ARM)
2026-09-08 20:01 ` Lorenzo Stoakes (ARM)
2026-09-08 20:24 ` sashiko-bot
2026-09-08 20:01 ` [PATCH 06/39] mm/vma: tidy up map kernel pages enum values Lorenzo Stoakes (ARM)
2026-09-08 20:01 ` Lorenzo Stoakes (ARM)
2026-09-08 20:27 ` sashiko-bot
2026-09-08 20:01 ` [PATCH 07/39] mm: add mmap action for discontiguous kernel page mapping Lorenzo Stoakes (ARM)
2026-09-08 20:01 ` Lorenzo Stoakes (ARM)
2026-09-08 20:34 ` sashiko-bot
2026-09-08 20:01 ` [PATCH 08/39] docs: filesystems: update mmap_prepare docs for discontig kernel pgs Lorenzo Stoakes (ARM)
2026-09-08 20:01 ` Lorenzo Stoakes (ARM)
2026-09-08 20:38 ` sashiko-bot
2026-09-08 20:01 ` [PATCH 09/39] drivers/usb/mon: update to use mmap_prepare + map kernel pages Lorenzo Stoakes (ARM)
2026-09-08 20:01 ` Lorenzo Stoakes (ARM)
2026-09-08 20:35 ` sashiko-bot
2026-09-09 7:37 ` Greg Kroah-Hartman
2026-09-09 7:37 ` Greg Kroah-Hartman
2026-09-08 20:01 ` [PATCH 10/39] infiniband: update hfi1 to use remap_vmalloc_range() Lorenzo Stoakes (ARM)
2026-09-08 20:01 ` Lorenzo Stoakes (ARM)
2026-09-08 20:42 ` sashiko-bot
2026-09-08 20:01 ` [PATCH 11/39] selinux: reject writable opens of policy file, drop mmap shared/write check Lorenzo Stoakes (ARM)
2026-09-08 20:01 ` Lorenzo Stoakes (ARM)
2026-09-08 20:22 ` Jann Horn
2026-09-08 20:22 ` Jann Horn
2026-09-11 10:13 ` Lorenzo Stoakes (ARM)
2026-09-11 10:13 ` Lorenzo Stoakes (ARM)
2026-09-08 20:36 ` sashiko-bot
2026-09-10 18:11 ` Stephen Smalley
2026-09-10 18:11 ` Stephen Smalley
2026-09-11 10:16 ` Lorenzo Stoakes (ARM)
2026-09-11 10:16 ` Lorenzo Stoakes (ARM)
2026-09-11 15:05 ` Stephen Smalley
2026-09-11 15:05 ` Stephen Smalley
2026-09-08 20:01 ` [PATCH 12/39] ALSA: pcm: use vm_insert_page() to map PCM status page Lorenzo Stoakes (ARM)
2026-09-08 20:01 ` Lorenzo Stoakes (ARM)
2026-09-08 20:45 ` sashiko-bot
2026-09-10 16:15 ` Takashi Iwai
2026-09-10 16:15 ` Takashi Iwai
2026-09-08 20:01 ` [PATCH 13/39] bpf: arena: mark arena_map_mmap() mappings VM_MIXEDMAP Lorenzo Stoakes (ARM)
2026-09-08 20:01 ` Lorenzo Stoakes (ARM)
2026-09-08 20:34 ` sashiko-bot
2026-09-08 20:01 ` [PATCH 14/39] mm/vma: add vma[_flags]_is_kernel_owned() predicates Lorenzo Stoakes (ARM)
2026-09-08 20:01 ` Lorenzo Stoakes (ARM)
2026-09-08 20:28 ` sashiko-bot
2026-09-08 20:01 ` [PATCH 15/39] mm/vma: only allow mmap to clear VMA_MAYWRITE_BIT if kernel-owned Lorenzo Stoakes (ARM)
2026-09-08 20:01 ` Lorenzo Stoakes (ARM)
2026-09-08 20:42 ` sashiko-bot
2026-09-08 20:01 ` [PATCH 16/39] mm/vma: add and use vma_[flags]_is_fixed_mapping Lorenzo Stoakes (ARM)
2026-09-08 20:01 ` Lorenzo Stoakes (ARM)
2026-09-08 20:42 ` sashiko-bot
2026-09-08 20:01 ` [PATCH 17/39] scsi: sg: convert mmap hook to mmap_prepare and rework Lorenzo Stoakes (ARM)
2026-09-08 20:01 ` Lorenzo Stoakes (ARM)
2026-09-08 20:37 ` sashiko-bot
2026-09-08 20:01 ` [PATCH 18/39] fbdev: defio: assert FBINFO_VIRTFB, drop VM_IO, add VM_MIXEDMAP Lorenzo Stoakes (ARM)
2026-09-08 20:01 ` Lorenzo Stoakes (ARM)
2026-09-08 20:39 ` sashiko-bot
2026-09-11 11:05 ` Thomas Zimmermann
2026-09-11 11:05 ` Thomas Zimmermann
2026-09-08 20:01 ` [PATCH 19/39] HSI: cmt_speech: convert mmap hook to mmap_prepare, refactor Lorenzo Stoakes (ARM)
2026-09-08 20:01 ` Lorenzo Stoakes (ARM)
2026-09-08 20:36 ` sashiko-bot
2026-09-08 20:01 ` [PATCH 20/39] mm/gup: error out early on !VMA_MAYREAD_BIT VMAs Lorenzo Stoakes (ARM)
2026-09-08 20:01 ` Lorenzo Stoakes (ARM)
2026-09-08 20:36 ` sashiko-bot
2026-09-08 20:01 ` [PATCH 21/39] uprobes: remove VM_IO, set VM_MIXEDMAP for mapped kernel pages Lorenzo Stoakes (ARM)
2026-09-08 20:01 ` Lorenzo Stoakes (ARM)
2026-09-08 20:36 ` sashiko-bot
2026-09-08 20:01 ` [PATCH 22/39] mm/mlock: clear VMA_LOCKED_MASK over mmap callback Lorenzo Stoakes (ARM)
2026-09-08 20:01 ` Lorenzo Stoakes (ARM)
2026-09-08 20:38 ` sashiko-bot
2026-09-08 20:01 ` [PATCH 23/39] mm/mlock: eliminate weird VMA_IO_BIT abuse and simplify Lorenzo Stoakes (ARM)
2026-09-08 20:01 ` Lorenzo Stoakes (ARM)
2026-09-08 20:47 ` sashiko-bot
2026-09-08 20:01 ` [PATCH 24/39] mm/vma: enforce that only kernel-owned mappings may set VMA_IO_BIT Lorenzo Stoakes (ARM)
2026-09-08 20:01 ` Lorenzo Stoakes (ARM)
2026-09-08 20:47 ` sashiko-bot
2026-09-08 20:01 ` [PATCH 25/39] mm: remove VMA_IO_BIT check in vma[_flags]_is_kernel_owned() Lorenzo Stoakes (ARM)
2026-09-08 20:01 ` Lorenzo Stoakes (ARM)
2026-09-08 20:37 ` sashiko-bot
2026-09-08 20:01 ` [PATCH 26/39] mm: remove hugetlb_inline.h Lorenzo Stoakes (ARM)
2026-09-08 20:01 ` Lorenzo Stoakes (ARM)
2026-09-08 20:34 ` sashiko-bot
2026-09-08 20:01 ` [PATCH 27/39] mm: rename is_vm_hugetlb_page() to vma_is_hugetlb() Lorenzo Stoakes (ARM)
2026-09-08 20:01 ` Lorenzo Stoakes (ARM)
2026-09-08 20:40 ` sashiko-bot
2026-09-09 11:09 ` Anup Patel
2026-09-09 11:09 ` Anup Patel
2026-09-09 11:22 ` Claudio Imbrenda
2026-09-09 11:30 ` Lorenzo Stoakes (ARM)
2026-09-09 13:20 ` Claudio Imbrenda
2026-09-09 12:07 ` Marc Zyngier
2026-09-09 12:07 ` Marc Zyngier
2026-09-08 20:01 ` [PATCH 28/39] mm: drop some redundant checks around hugetlb VMAs Lorenzo Stoakes (ARM)
2026-09-08 20:01 ` Lorenzo Stoakes (ARM)
2026-09-08 20:39 ` sashiko-bot [this message]
2026-09-09 12:08 ` Marc Zyngier
2026-09-09 12:08 ` Marc Zyngier
2026-09-08 20:01 ` [PATCH 29/39] mm/madvise: update is_valid_guard_vma() to use vma_can_merge() Lorenzo Stoakes (ARM)
2026-09-08 20:01 ` Lorenzo Stoakes (ARM)
2026-09-08 20:45 ` sashiko-bot
2026-09-08 20:01 ` [PATCH 30/39] mm/vma: introduce vma[_flags]_is_persistent() Lorenzo Stoakes (ARM)
2026-09-08 20:01 ` Lorenzo Stoakes (ARM)
2026-09-08 20:47 ` sashiko-bot
2026-09-08 20:01 ` [PATCH 31/39] mm/uffd: use predicates for userfaultfd checks Lorenzo Stoakes (ARM)
2026-09-08 20:01 ` Lorenzo Stoakes (ARM)
2026-09-08 20:45 ` sashiko-bot
2026-09-08 20:01 ` [PATCH 32/39] mm/madvise: use predicates for madvise(..., MADV_DOFORK) Lorenzo Stoakes (ARM)
2026-09-08 20:01 ` Lorenzo Stoakes (ARM)
2026-09-08 20:48 ` sashiko-bot
2026-09-08 20:01 ` [PATCH 33/39] mm: eliminate VMA_SPECIAL_FLAGS usage when hugetlb explicitly tested Lorenzo Stoakes (ARM)
2026-09-08 20:01 ` Lorenzo Stoakes (ARM)
2026-09-08 20:42 ` sashiko-bot
2026-09-08 20:01 ` [PATCH 34/39] mm: eliminate VMA_SPECIAL_FLAGS check in lru_gen_look_around() Lorenzo Stoakes (ARM)
2026-09-08 20:01 ` Lorenzo Stoakes (ARM)
2026-09-08 20:45 ` sashiko-bot
2026-09-08 20:01 ` [PATCH 35/39] mm: avoid use of VMA_SPECIAL_FLAGS in migrate_vma_setup() Lorenzo Stoakes (ARM)
2026-09-08 20:01 ` Lorenzo Stoakes (ARM)
2026-09-08 20:47 ` sashiko-bot
2026-09-08 20:01 ` [PATCH 36/39] mm: eliminate VM_SPECIAL, VMA_SPECIAL_FLAGS Lorenzo Stoakes (ARM)
2026-09-08 20:01 ` Lorenzo Stoakes (ARM)
2026-09-08 20:41 ` sashiko-bot
2026-09-08 20:01 ` [PATCH 37/39] fuse: dax: do not set VM_MIXEDMAP Lorenzo Stoakes (ARM)
2026-09-08 20:01 ` Lorenzo Stoakes (ARM)
2026-09-08 20:50 ` sashiko-bot
2026-09-08 20:01 ` [PATCH 38/39] mm/huge_memory: remove vma_is_special_huge() Lorenzo Stoakes (ARM)
2026-09-08 20:01 ` Lorenzo Stoakes (ARM)
2026-09-08 20:45 ` sashiko-bot
2026-09-08 20:01 ` [PATCH 39/39] mm/vma: introduce and use vma[_flags]_can_gup() Lorenzo Stoakes (ARM)
2026-09-08 20:01 ` Lorenzo Stoakes (ARM)
2026-09-08 20:44 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260908204000.670501F00A3A@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=bpf@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=ljs@kernel.org \
--cc=maz@kernel.org \
--cc=oupton@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.