All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Roth <michael.roth@amd.com>
To: <qemu-devel@nongnu.org>
Cc: <kvm@vger.kernel.org>, <pbonzini@redhat.com>,
	<berrange@redhat.com>, <armbru@redhat.com>,
	<pankaj.gupta@amd.com>, <isaku.yamahata@intel.com>,
	<xiaoyao.li@intel.com>, <chao.p.peng@linux.intel.com>,
	<david@kernel.org>, <ashish.kalra@amd.com>,
	<ackerleytng@google.com>, <lpieralisi@kernel.org>
Subject: [PATCH v2 10/19] system/memory: Default to guest_memfd for RAM for in-place conversion
Date: Tue, 8 Sep 2026 15:48:30 -0500	[thread overview]
Message-ID: <20260908205236.838281-11-michael.roth@amd.com> (raw)
In-Reply-To: <20260908205236.838281-1-michael.roth@amd.com>

memory_region_init_ram_guest_memfd_private() is called in some cases
(legacy BIOS regions / IGVM regions) to allocate a new RAM region with a
guest_memfd FD under the covers to handle private memory since the GPA
range can be converted between shared/private guest RAM.

When in-place conversion is enabled, the conversions happen with the
guest_memfd inode itself, so the same inode must be used for both shared
and private memory. Handle this accordingly when convert-in-place=true.

Signed-off-by: Michael Roth <michael.roth@amd.com>
---
 system/memory.c | 23 ++++++++++++++++++++---
 1 file changed, 20 insertions(+), 3 deletions(-)

diff --git a/system/memory.c b/system/memory.c
index b3b678617b..ba3ef27b58 100644
--- a/system/memory.c
+++ b/system/memory.c
@@ -3623,10 +3623,27 @@ bool memory_region_init_ram_guest_memfd_private(MemoryRegion *mr,
                                                 uint64_t size,
                                                 Error **errp)
 {
-    if (!memory_region_init_ram_flags_nomigrate(mr, owner, name, size,
-                                                RAM_GUEST_MEMFD_PRIVATE, errp)) {
-        return false;
+    if (machine_require_guest_memfd_convert_in_place(current_machine)) {
+        int fd = kvm_create_guest_memfd(size, errp);
+        if (fd < 0) {
+            return false;
+        }
+
+        if (!memory_region_init_ram_from_fd(mr, owner, name, size,
+                                            RAM_SHARED |
+                                            RAM_GUEST_MEMFD_PRIVATE |
+                                            RAM_GUEST_MEMFD_SHARED,
+                                            fd, 0, errp)) {
+            close(fd);
+            return false;
+        }
+    } else {
+        if (!memory_region_init_ram_flags_nomigrate(mr, owner, name, size,
+                                                    RAM_GUEST_MEMFD_PRIVATE, errp)) {
+            return false;
+        }
     }
+
     memory_region_register_ram(mr, owner);
     return true;
 }
-- 
2.43.0


  parent reply	other threads:[~2026-09-08 20:53 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-08 20:48 [PATCH v2 00/19] guest_memfd: support in-place memory conversion Michael Roth
2026-09-08 20:48 ` [PATCH v2 01/19] accel/kvm: Add helper for handling conversions of MMIO holes Michael Roth
2026-09-08 20:48 ` [PATCH v2 02/19] accel/kvm: Fix kvm_convert_memory() calls crossing memory regions Michael Roth
2026-09-08 20:48 ` [PATCH v2 03/19] accel/kvm: Fix handling of MMIO holes at start of conversion ranges Michael Roth
2026-09-08 20:48 ` [PATCH v2 04/19] accel/kvm: Fix handling of conversion ranges with multiple MMIO holes Michael Roth
2026-09-08 20:48 ` [PATCH v2 05/19] accel/kvm: Use dedicated helper for creating private-only gmem instances Michael Roth
2026-09-08 20:48 ` [PATCH v2 06/19] linux-headers: Update headers for v12 of in-place conversion kernel support Michael Roth
2026-09-08 20:48 ` [PATCH v2 07/19] accel/kvm: Add CGS option to control in-place conversion support Michael Roth
2026-09-09  6:20   ` Markus Armbruster
2026-09-11 17:22     ` Michael Roth
2026-09-12  5:52       ` Markus Armbruster
2026-09-12 14:52         ` Michael Roth
2026-09-08 20:48 ` [PATCH v2 08/19] system/memory: Re-use memory-backend-guest-memfd inode for private memory Michael Roth
2026-09-10  8:39   ` David Hildenbrand
2026-09-11 19:07     ` Michael Roth
2026-09-08 20:48 ` [PATCH v2 09/19] accel/kvm: Handle guest_memfd flags internally when creating instances Michael Roth
2026-09-08 20:48 ` Michael Roth [this message]
2026-09-08 20:48 ` [PATCH v2 11/19] accel/kvm: Move post-conversion updates to a separate helper Michael Roth
2026-09-08 20:48 ` [PATCH v2 12/19] accel/kvm: Re-order attribute notifications for in-place conversion Michael Roth
2026-09-08 20:48 ` [PATCH v2 13/19] accel/kvm: Support shared/private conversions via guest_memfd ioctls Michael Roth
2026-09-08 20:48 ` [PATCH v2 14/19] accel/kvm: Don't default to private attributes for in-place conversion Michael Roth
2026-09-08 20:48 ` [PATCH v2 15/19] i386/sev: Update SNP_LAUNCH_UPDATE " Michael Roth
2026-09-08 20:48 ` [PATCH v2 16/19] i386/sev: Allow in-place conversion for SEV-SNP guests Michael Roth
2026-09-08 20:48 ` [PATCH v2 17/19] i386/sev: Update CPUID failure handling for in-place conversion Michael Roth
2026-09-08 20:48 ` [PATCH v2 18/19] accel/kvm: Disable discard " Michael Roth
2026-09-08 22:16   ` Michael Roth
2026-09-08 20:48 ` [PATCH v2 19/19] hostmem: Automatically select set guest-memfd=on " Michael Roth
2026-09-09  6:30   ` Markus Armbruster
2026-09-11 19:16     ` Michael Roth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260908205236.838281-11-michael.roth@amd.com \
    --to=michael.roth@amd.com \
    --cc=ackerleytng@google.com \
    --cc=armbru@redhat.com \
    --cc=ashish.kalra@amd.com \
    --cc=berrange@redhat.com \
    --cc=chao.p.peng@linux.intel.com \
    --cc=david@kernel.org \
    --cc=isaku.yamahata@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=pankaj.gupta@amd.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=xiaoyao.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.