Re: [PATCH v12 2/7] mmc: k1: add sdhci platform driver

[Yixun Lan <dlan@kernel.org>]

Hi Eric,

On 00:27 Tue 08 Sep     , Eric Chung wrote:
> On Mon, Sep 7, 2026 at 4:33 PM Yao Zi <me@ziyao.cc> wrote:
> >
..
> > > --- /dev/null
> > > +++ b/drivers/mmc/spacemit_sdhci.c
> > > @@ -0,0 +1,684 @@
> >
> > ...
> >
> > > +#define SPACEMIT_RX_DLINE_REG                9
> >
> > There's an on-going series containing fixes for SpacemiT MMC controllers
> > in Linux upstream, and I noticed this patch carries same issues for the
> > delay granularity[1] and minimum RX tuning window[2]. Should it be fixed?
> >
> > ...
> >
> > > +static int spacemit_sdhci_execute_tuning(struct mmc *mmc, u8 opcode)
> > > +{
> >
> > ...
> >
> > > +     if (max_pass_len < 3) {
> > > +             log_err("Tuning failed: no stable window found\n");
> > > +             return -EIO;
> > > +     }
> >
> > and here.
> >
> > Best regards,
> > Yao Zi
> >
> > [1]: https://lore.kernel.org/spacemit/20260902-07-k3-sdhci-fix-v1-5-b15c5d0f64fd@kernel.org/
> > [2]: https://lore.kernel.org/spacemit/20260902-07-k3-sdhci-fix-v1-6-b15c5d0f64fd@kernel.org/
> 
> OK. I'll include them.

I'm fine if you do this since the patches are quite trivial, but that series is 
mainly targeting for sdio support

-- 
Yixun Lan (dlan)