Re: [PATCH] arm64: dts: imx8mm: imx8mp: Update EEPROM with nWP GPIO, label and layout

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Devicetree unit address mismatch for `wifi-id` node
--

commit 082793f42f1059431835df44206b8d1014d852b6
Author: Marek Vasut <marex@nabladev.com>

arm64: dts: imx8mm: imx8mp: Update EEPROM with nWP GPIO, label and layout

This commit describes the ID EEPROM nWP GPIO, label, and nvmem layout for
the i.MX8MM and i.MX8MP eDM SBCs.

> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts b/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
> index 472c584fb3bd2..92df23e432499 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts

[ ... ]

> +			board-id@100 {
> +				reg = <0x100 0x4>;
> +			};
> +
> +			wifi-id@1200 {
> +				reg = <0x120 0x4>;
> +			};

[Severity: Low]
Does this unit address mismatch the reg property? The node name uses 1200,
but the base address in the reg property is 120. This will likely cause a
dtc compiler warning for a simple-bus unit address format error.

> +		};
>  	};

> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts b/arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts
> index cb28cf1cdd23f..dbdf4b8f696f6 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts

[ ... ]

> +			board-id@100 {
> +				reg = <0x100 0x4>;
> +			};
> +
> +			wifi-id@1200 {
> +				reg = <0x120 0x4>;
> +			};

[Severity: Low]
Is the unit address 1200 a typo here as well? The reg property specifies 120
for the i.MX8MP SBC rev.900, which does not match the node name.

[ ... ]

> +			board-id@100 {
> +				reg = <0x100 0x4>;
> +			};
> +
> +			wifi-id@1200 {
> +				reg = <0x120 0x4>;
> +			};

[Severity: Low]
Similarly for the i.MX8MP SBC rev.902, should this unit address be updated
to match the 120 specified in the reg property?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908215519.33061-1-marex@nabladev.com?part=1