From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.netfilter.org (mail.netfilter.org [217.70.190.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5ED648F00A for ; Tue, 8 Sep 2026 22:16:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.190.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788905778; cv=none; b=ougZIQHt5J89UUggMsR6z5wvEj9sduxlz7YQv0kVuKdPeaTzTqnysaKXn4G6/gvtszfn80lY1GRsXQ1Yd9QyONgPa/9Sh5/5hoNuUZ5qcLOqcgJyuMrAhUgY5DCUfMveFSak2kn78WWY5AWVK1RsK6mQno736gmvmJiQCXbAKIg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788905778; c=relaxed/simple; bh=jrT3oX3mKDFRjtRI9PnG7RCHgOxUNE7JlN4gfGGVCqo=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=Iq1c29ftk/1l1lRV45V4MBuj/q6CANbl4sb1jXI1PILAFI3uOtnpkxxQcZPH2YG/Lwx8Kr2BR4JEWH1UXuFpSWjsSvlnUqIM0OGGgWH1AKz2QCm/pfSwQKSHSmGsrIm1LWX/3A5oT+T6Nehk7U59Qwqi9qaoPQGx2YfWtdJcNlA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=netfilter.org; spf=pass smtp.mailfrom=netfilter.org; dkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org header.b=ogLfZtRu; arc=none smtp.client-ip=217.70.190.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=netfilter.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=netfilter.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org header.b="ogLfZtRu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netfilter.org; s=2025; t=1788905773; bh=3K1cdcG7lCMhwb2HmdLaCPOZtjgB80js8r3x1WzuzTA=; h=From:To:Subject:Date:From; b=ogLfZtRu9YjS2bvXW3hRdKLm2iAV6polfGxx46CH0oX0tkJLH3t0gcgjDuJRx2Atm rpZdQzqda8WlteUf3qfkT5bcZ66OnHlEyb5xxskL1hxDeR2v+MjfeGoHULpAzBQL74 5XWj1R5ywXXcqsRzvXwjgKPdKrnKLGfCxTaEWVDVXYtwpSbMeKTQ+FrIbdotRYyU9S k9GNu+n7grgeq71hgsW9Aw5DeNd9vVRIAyjk7bpw8Y3qewRcWZFfQFRYZZTiiHr7sl X0Sw0VdyePPCs1QowqBQzbCg6qGtkaMedjwWNnfatAbkyrbaFjs+zfxXh5BbeO0AlR FhH/zZhWkPirA== Received: from localhost.localdomain (mail-agni [217.70.190.124]) by mail.netfilter.org (Postfix) with ESMTPSA id 346E960765 for ; Wed, 9 Sep 2026 00:16:13 +0200 (CEST) From: Pablo Neira Ayuso To: netfilter-devel@vger.kernel.org Subject: [PATCH nf] netfilter: set on this module via struct netlink_dump_control Date: Wed, 9 Sep 2026 00:16:10 +0200 Message-ID: <20260908221610.1524744-1-pablo@netfilter.org> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: netfilter-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Modules can be removed in the middle of a netlink dump. Set .module to THIS_MODULE in struct netlink_dump_control to hold a reference on the module while netlink dump is in progress. See commit 6dc878a8ca39 ("netlink: add reference of module in netlink_dump_start") which describes this problem. Fixes: a7b4f989a629 ("netfilter: ipset: IP set core support") Fixes: c1d10adb4a52 ("[NETFILTER]: Add ctnetlink port for nf_conntrack") Fixes: 50978462300f ("netfilter: add cttimeout infrastructure for fine timeout tuning") Fixes: 9413902796f5 ("netfilter: add extended accounting infrastructure over nfnetlink") Fixes: 12f7a505331e ("netfilter: add user-space connection tracking helper infrastructure") Signed-off-by: Pablo Neira Ayuso --- net/netfilter/ipset/ip_set_core.c | 1 + net/netfilter/nf_conntrack_netlink.c | 7 +++++++ net/netfilter/nfnetlink_acct.c | 1 + net/netfilter/nfnetlink_cthelper.c | 1 + net/netfilter/nfnetlink_cttimeout.c | 1 + 5 files changed, 11 insertions(+) diff --git a/net/netfilter/ipset/ip_set_core.c b/net/netfilter/ipset/ip_set_core.c index 0a86a170ba90..624c5f14acf6 100644 --- a/net/netfilter/ipset/ip_set_core.c +++ b/net/netfilter/ipset/ip_set_core.c @@ -1733,6 +1733,7 @@ static int ip_set_dump(struct sk_buff *skb, const struct nfnl_info *info, .start = ip_set_dump_start, .dump = ip_set_dump_do, .done = ip_set_dump_done, + .module = THIS_MODULE, }; return netlink_dump_start(info->sk, skb, info->nlh, &c); } diff --git a/net/netfilter/nf_conntrack_netlink.c b/net/netfilter/nf_conntrack_netlink.c index 579ada063b1b..2340885b2076 100644 --- a/net/netfilter/nf_conntrack_netlink.c +++ b/net/netfilter/nf_conntrack_netlink.c @@ -1682,6 +1682,7 @@ static int ctnetlink_get_conntrack(struct sk_buff *skb, .start = ctnetlink_start, .dump = ctnetlink_dump_table, .done = ctnetlink_done, + .module = THIS_MODULE, .data = (void *)cda, }; @@ -1826,6 +1827,7 @@ static int ctnetlink_get_ct_dying(struct sk_buff *skb, if (info->nlh->nlmsg_flags & NLM_F_DUMP) { struct netlink_dump_control c = { .dump = ctnetlink_dump_dying, + .module = THIS_MODULE, }; return netlink_dump_start(info->sk, skb, info->nlh, &c); } @@ -1840,6 +1842,7 @@ static int ctnetlink_get_ct_unconfirmed(struct sk_buff *skb, if (info->nlh->nlmsg_flags & NLM_F_DUMP) { struct netlink_dump_control c = { .dump = ctnetlink_dump_unconfirmed, + .module = THIS_MODULE, }; return netlink_dump_start(info->sk, skb, info->nlh, &c); } @@ -2555,6 +2558,7 @@ static int ctnetlink_stat_ct_cpu(struct sk_buff *skb, if (info->nlh->nlmsg_flags & NLM_F_DUMP) { struct netlink_dump_control c = { .dump = ctnetlink_ct_stat_cpu_dump, + .module = THIS_MODULE, }; return netlink_dump_start(info->sk, skb, info->nlh, &c); } @@ -3278,6 +3282,7 @@ static int ctnetlink_dump_exp_ct(struct net *net, struct sock *ctnl, .dump = ctnetlink_exp_ct_dump_table, .start = ctnetlink_dump_exp_ct_start, .done = ctnetlink_dump_exp_ct_done, + .module = THIS_MODULE, }; err = ctnetlink_parse_tuple(cda, &tuple, CTA_EXPECT_MASTER, @@ -3327,6 +3332,7 @@ static int ctnetlink_get_expect(struct sk_buff *skb, else { struct netlink_dump_control c = { .dump = ctnetlink_exp_dump_table, + .module = THIS_MODULE, }; return netlink_dump_start(info->sk, skb, info->nlh, &c); } @@ -3748,6 +3754,7 @@ static int ctnetlink_stat_exp_cpu(struct sk_buff *skb, if (info->nlh->nlmsg_flags & NLM_F_DUMP) { struct netlink_dump_control c = { .dump = ctnetlink_exp_stat_cpu_dump, + .module = THIS_MODULE, }; return netlink_dump_start(info->sk, skb, info->nlh, &c); } diff --git a/net/netfilter/nfnetlink_acct.c b/net/netfilter/nfnetlink_acct.c index 8ff1e0ad5cb0..39a62bb9a6e6 100644 --- a/net/netfilter/nfnetlink_acct.c +++ b/net/netfilter/nfnetlink_acct.c @@ -284,6 +284,7 @@ static int nfnl_acct_get(struct sk_buff *skb, const struct nfnl_info *info, .dump = nfnl_acct_dump, .start = nfnl_acct_start, .done = nfnl_acct_done, + .module = THIS_MODULE, .data = (void *)tb[NFACCT_FILTER], }; diff --git a/net/netfilter/nfnetlink_cthelper.c b/net/netfilter/nfnetlink_cthelper.c index 5b6a09f46903..1331aba007ba 100644 --- a/net/netfilter/nfnetlink_cthelper.c +++ b/net/netfilter/nfnetlink_cthelper.c @@ -644,6 +644,7 @@ static int nfnl_cthelper_get(struct sk_buff *skb, const struct nfnl_info *info, if (info->nlh->nlmsg_flags & NLM_F_DUMP) { struct netlink_dump_control c = { .dump = nfnl_cthelper_dump_table, + .module = THIS_MODULE, }; return netlink_dump_start(info->sk, skb, info->nlh, &c); } diff --git a/net/netfilter/nfnetlink_cttimeout.c b/net/netfilter/nfnetlink_cttimeout.c index 132c02ac7c4e..29de875d1713 100644 --- a/net/netfilter/nfnetlink_cttimeout.c +++ b/net/netfilter/nfnetlink_cttimeout.c @@ -277,6 +277,7 @@ static int cttimeout_get_timeout(struct sk_buff *skb, if (info->nlh->nlmsg_flags & NLM_F_DUMP) { struct netlink_dump_control c = { .dump = ctnl_timeout_dump, + .module = THIS_MODULE, }; return netlink_dump_start(info->sk, skb, info->nlh, &c); } -- 2.47.3