From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D359F2F3621 for ; Tue, 8 Sep 2026 12:22:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788870180; cv=none; b=JDiDGuOdSdJMYFS595J9EyGni+YMLwdJYXQ2yGfaBeoGP4kwbK9EUzsPbg/XAiGXzipUSFGKwNaSVbNMffZwBXwvbaGgk/H6TC871FPZDzZOzYvuvY7Y9OAgpQ7uvxHqDh1T19e/6SJXYKQgwlmgpZVZzRxhUY9Qs4PJTPVtokc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788870180; c=relaxed/simple; bh=POlSHzVAa38Z/3fxgWDlXJXHCNpMU+0Xbfd89SONpXU=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=htWl26tVDI1Wl3ad4z+U06v4x+j5hj/IHbLxwMsPhBLZOLms+2fA32QJQMTSsZCm6ZT/422RsBflxvXCtJcm+C26l+oNqdSo97w7roOWBAIL1SbgVDHGjb7CoAIL/Q78LKQUcG99jTV+U+DIwX4gMtA/EqJFdjf/aQ2G0K1P7Rg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=S+GdQm1H; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="S+GdQm1H" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2FD21F00A3A; Tue, 8 Sep 2026 12:22:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1788870178; bh=KnBCqBHEZSRTwZI+Z0+xA6tK38zvEQfvpp2BC7RUyKw=; h=Subject:To:Cc:From:Date; b=S+GdQm1HZ/r2KVYFIKlofaAMVGAYr9mcSqLzI6KUXHpjhQkaD4sJEA6tygxffdBc+ 7RRtWQndK/1iZ5TvIzd54Sm/NjHOltwU8aHOX95bIDOPulujuVp1hvJ/EPo6TnHSWG +VfH6RcWpHBBJho8V7LaMTRFd22psYM+6bRPSg5w= Subject: FAILED: patch "[PATCH] usb: storage: realtek_cr: fix use-after-free on disconnect" failed to apply to 5.10-stable tree To: mhun512@gmail.com,ae878000@gmail.com,gregkh@linuxfoundation.org,stable@kernel.org Cc: From: Date: Tue, 08 Sep 2026 14:22:33 +0200 Message-ID: <2026090833-elongated-limpness-ff29@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x 4ffee1aebb0c0ffcda9faffd17834ea9b00d42cc # git commit -s git send-email --to '' --in-reply-to '2026090833-elongated-limpness-ff29@gregkh' --subject-prefix 'PATCH 5.10.y' 'HEAD^..' Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 4ffee1aebb0c0ffcda9faffd17834ea9b00d42cc Mon Sep 17 00:00:00 2001 From: Myeonghun Pak Date: Mon, 27 Jul 2026 21:34:14 +0900 Subject: [PATCH] usb: storage: realtek_cr: fix use-after-free on disconnect realtek_cr_destructor() calls timer_delete() before the chip containing the timer is freed. The timer callback may still be running and can rearm itself, resulting in a use-after-free. Use timer_shutdown_sync() to wait for the callback and prevent further rearming. Do this unconditionally because ss_en may be changed after the timer is armed. Move timer_setup() into init_realtek_cr() so the timer is initialized before any failure path can invoke the destructor. Found by static analysis. Fixes: e931830bb877 ("Realtek cr: Add autosuspend function.") Cc: stable Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak Link: https://patch.msgid.link/20260727123414.44700-1-mhun512@gmail.com Signed-off-by: Greg Kroah-Hartman diff --git a/drivers/usb/storage/realtek_cr.c b/drivers/usb/storage/realtek_cr.c index af038b897c6b..c4b28744693b 100644 --- a/drivers/usb/storage/realtek_cr.c +++ b/drivers/usb/storage/realtek_cr.c @@ -916,7 +916,6 @@ static int realtek_cr_autosuspend_setup(struct us_data *us) us->proto_handler = rts51x_invoke_transport; chip->timer_expires = 0; - timer_setup(&chip->rts51x_suspend_timer, rts51x_suspend_timer_fn, 0); fw5895_init(us); /* enable autosuspend function of the usb device */ @@ -934,10 +933,7 @@ static void realtek_cr_destructor(void *extra) return; #ifdef CONFIG_REALTEK_AUTOPM - if (ss_en) { - timer_delete(&chip->rts51x_suspend_timer); - chip->timer_expires = 0; - } + timer_shutdown_sync(&chip->rts51x_suspend_timer); #endif kfree(chip->status); } @@ -982,6 +978,9 @@ static int init_realtek_cr(struct us_data *us) us->extra = chip; us->extra_destructor = realtek_cr_destructor; +#ifdef CONFIG_REALTEK_AUTOPM + timer_setup(&chip->rts51x_suspend_timer, rts51x_suspend_timer_fn, 0); +#endif us->max_lun = chip->max_lun = rts51x_get_max_lun(us); chip->us = us;