Re: [PATCH] selftests: damon: add script dir to sys.path for PYTHONSAFEPATH compatibility

[SJ Park <sj@kernel.org>]

Hi Eva,

On Tue, 08 Sep 2026 21:48:17 +0000 sashiko-bot@kernel.org wrote:

> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] The patch claims to fix PYTHONSAFEPATH compatibility for all DAMON Python selftests, but misses 3 test scripts, leading to an incomplete fix and a commit message mismatch.
> --
> 
> commit 3a3c43c4b8c811027e52bf0fa5b68c48216e86c4
> Author: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
> 
> selftests: damon: add script dir to sys.path for PYTHONSAFEPATH compatibility
> 
> This commit adds the script's directory to sys.path for several DAMON Python
> selftests to fix ModuleNotFoundError issues when running under Python's safe
> path mode. It claims to fix all 7 tests that import the _damon_sysfs helper
> module.
> 
> >     This breaks all 7 DAMON Python selftests that import the _damon_sysfs
> >     helper module located in the same directory:
> 
> [Severity: Medium]
> Are there more than 7 tests affected by this? It looks like sysfs.py,
> sysfs_refresh.py, and sysfs_no_op_commit_break.py in
> tools/testing/selftests/damon/ also import _damon_sysfs but lack the
> sys.path.append() workaround introduced in this commit.
> 
> If these tests are run with PYTHONSAFEPATH set in the environment or with -P
> on the interpreter command line, will they continue to fail with a
> ModuleNotFoundError?

I think this is not a blocker of your patch, but could you please confirm if
Sashiko's finding is correct, and if you have a plan to fix those in future?

> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/20260908214238.2680324-1-eva.kurchatova@virtuozzo.com?part=1
> 


Thanks,
SJ