All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: David Howells <dhowells@redhat.com>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
	Paulo Alcantara <pc@manguebit.org>
Subject: [dhowells-fs:netfs-next-1 6/8] fs/netfs/buffered_read.c:245:26: error: use of undeclared identifier 'NETFS_RREQ_USE_PGPRIV2'
Date: Wed, 09 Sep 2026 00:11:49 +0200	[thread overview]
Message-ID: <202609090040.XYKriffI-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git netfs-next-1
head:   bf6f26c5281fa05cf8c97025dcb2f7f87143138a
commit: 9266aba94da4bdfc7ff858c8191ef647e3067c15 [6/8] netfs: Make deprecated PG_private_2 support opt-in
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20260909/202609090040.XYKriffI-lkp@intel.com/config)
compiler: clang version 22.1.8 (https://github.com/llvm/llvm-project ca7933e47d3a3451d81e72ac174dcb5aa28b59d1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260909/202609090040.XYKriffI-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202609090040.XYKriffI-lkp@intel.com/

All errors (new ones prefixed by >>):

>> fs/netfs/buffered_read.c:245:26: error: use of undeclared identifier 'NETFS_RREQ_USE_PGPRIV2'
     245 |                         if (unlikely(test_bit(NETFS_RREQ_USE_PGPRIV2, &rreq->flags))) {
         |                                               ^~~~~~~~~~~~~~~~~~~~~~
>> fs/netfs/buffered_read.c:245:26: error: use of undeclared identifier 'NETFS_RREQ_USE_PGPRIV2'
     245 |                         if (unlikely(test_bit(NETFS_RREQ_USE_PGPRIV2, &rreq->flags))) {
         |                                               ^~~~~~~~~~~~~~~~~~~~~~
>> fs/netfs/buffered_read.c:245:26: error: use of undeclared identifier 'NETFS_RREQ_USE_PGPRIV2'
     245 |                         if (unlikely(test_bit(NETFS_RREQ_USE_PGPRIV2, &rreq->flags))) {
         |                                               ^~~~~~~~~~~~~~~~~~~~~~
   3 errors generated.


vim +/NETFS_RREQ_USE_PGPRIV2 +245 fs/netfs/buffered_read.c

e2d46f2ec33253 David Howells 2024-12-16  213  
533203c4183123 David Howells 2026-08-27  214  /*
533203c4183123 David Howells 2026-08-27  215   * Mark folios that we want to copy to the cache.  For filesystems that use
533203c4183123 David Howells 2026-08-27  216   * netfslib fully, we set folio->private to NETFS_FOLIO_COPY_TO_CACHE;
533203c4183123 David Howells 2026-08-27  217   * otherwise we set the deprecated PG_private_2.
533203c4183123 David Howells 2026-08-27  218   */
533203c4183123 David Howells 2026-08-27  219  static void netfs_mark_copy_to_cache(struct netfs_io_request *rreq,
533203c4183123 David Howells 2026-08-27  220  				     struct folio_queue **fq,
533203c4183123 David Howells 2026-08-27  221  				     unsigned int *offset,
533203c4183123 David Howells 2026-08-27  222  				     int *slot,
533203c4183123 David Howells 2026-08-27  223  				     size_t len,
533203c4183123 David Howells 2026-08-27  224  				     bool copy)
533203c4183123 David Howells 2026-08-27  225  {
533203c4183123 David Howells 2026-08-27  226  	while (len > 0) {
533203c4183123 David Howells 2026-08-27  227  		struct folio *folio;
533203c4183123 David Howells 2026-08-27  228  		size_t fsize, overlap;
533203c4183123 David Howells 2026-08-27  229  
533203c4183123 David Howells 2026-08-27  230  		if (!*fq)
533203c4183123 David Howells 2026-08-27  231  			break;
533203c4183123 David Howells 2026-08-27  232  		if (*slot >= folioq_count(*fq)) {
533203c4183123 David Howells 2026-08-27  233  			*fq = (*fq)->next;
533203c4183123 David Howells 2026-08-27  234  			*slot = 0;
533203c4183123 David Howells 2026-08-27  235  			*offset = 0;
533203c4183123 David Howells 2026-08-27  236  			continue;
533203c4183123 David Howells 2026-08-27  237  		}
533203c4183123 David Howells 2026-08-27  238  
533203c4183123 David Howells 2026-08-27  239  		/* Determine how much the subreq overlaps the folio, if at all. */
533203c4183123 David Howells 2026-08-27  240  		fsize = folioq_folio_size(*fq, *slot);
533203c4183123 David Howells 2026-08-27  241  		overlap = min(len, fsize - *offset);
533203c4183123 David Howells 2026-08-27  242  
533203c4183123 David Howells 2026-08-27  243  		if (overlap > 0 && copy) {
533203c4183123 David Howells 2026-08-27  244  			folio = folioq_folio(*fq, *slot);
533203c4183123 David Howells 2026-08-27 @245  			if (unlikely(test_bit(NETFS_RREQ_USE_PGPRIV2, &rreq->flags))) {
533203c4183123 David Howells 2026-08-27  246  				if (!folio_test_private_2(folio))
533203c4183123 David Howells 2026-08-27  247  					folio_start_private_2(folio);
533203c4183123 David Howells 2026-08-27  248  			} else {
533203c4183123 David Howells 2026-08-27  249  				if (!folio_get_private(folio))
533203c4183123 David Howells 2026-08-27  250  					folio_attach_private(folio, NETFS_FOLIO_COPY_TO_CACHE);
533203c4183123 David Howells 2026-08-27  251  			}
533203c4183123 David Howells 2026-08-27  252  			trace_netfs_folio(folio, netfs_folio_trace_mark_copy);
533203c4183123 David Howells 2026-08-27  253  		}
533203c4183123 David Howells 2026-08-27  254  
533203c4183123 David Howells 2026-08-27  255  		len -= overlap;
533203c4183123 David Howells 2026-08-27  256  		*offset += overlap;
533203c4183123 David Howells 2026-08-27  257  		if (*offset >= fsize) {
533203c4183123 David Howells 2026-08-27  258  			*slot += 1;
533203c4183123 David Howells 2026-08-27  259  			*offset = 0;
533203c4183123 David Howells 2026-08-27  260  		}
533203c4183123 David Howells 2026-08-27  261  	}
533203c4183123 David Howells 2026-08-27  262  }
533203c4183123 David Howells 2026-08-27  263  

:::::: The code at line 245 was first introduced by commit
:::::: 533203c4183123dad8ffecd694e7573a0ccd0da0 netfs: Mark folios with COPY_TO_CACHE whilst issuing subreqs

:::::: TO: David Howells <dhowells@redhat.com>
:::::: CC: Christian Brauner <brauner@kernel.org>

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2026-09-08 22:12 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202609090040.XYKriffI-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=dhowells@redhat.com \
    --cc=llvm@lists.linux.dev \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=pc@manguebit.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.