Re: [PATCH 04/16] gpu: nova-core: mm: pagetable: Add PteOps trait

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Vertical imports in the `crate::mm` block are not alphabetically sorted.
--

commit ee1cdc1cc3fda4aebff8e2ad80ace37f03baef14
Author: Joel Fernandes <joelagnelf@nvidia.com>

gpu: nova-core: mm: pagetable: Add PteOps trait

This introduces a trait for GPU Page Table Entries. New read and write
helpers are provided that go through a Pramin, allowing the later
page-table walker and mapper to call PTE operations.

> diff --git a/drivers/gpu/nova-core/mm/pagetable.rs b/drivers/gpu/nova-core/mm/pagetable.rs
> --- a/drivers/gpu/nova-core/mm/pagetable.rs
> +++ b/drivers/gpu/nova-core/mm/pagetable.rs
> @@ -8,9 +8,18 @@
>  
>  #![expect(dead_code)]
>  
> -use kernel::num::Bounded;
> +use kernel::{
> +    io::Io,
> +    num::Bounded,
> +    prelude::*, //
> +};
>  
>  use crate::gpu::Architecture;
> +use crate::mm::{
> +    pramin,
> +    Pfn,
> +    VramAddress, //
> +};

[Severity: Low]
This isn't a bug, but it looks like the vertical imports in the crate::mm
block are not alphabetically sorted. Should Pfn precede pramin to comply
with the Rust kernel coding guidelines for import formatting?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260909-mmrebase-v1-0-8dd5d4225d2e@nvidia.com?part=4