From: sashiko-bot@kernel.org
To: "SJ Park" <sj@kernel.org>
Cc: damon@lists.linux.dev
Subject: Re: [PATCH 6.12.y] mm/damon/vaddr: drop last same folio access check optimization
Date: Wed, 09 Sep 2026 06:09:51 +0000 [thread overview]
Message-ID: <20260909060952.20DBF1F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260909060130.269798-1-sj@kernel.org>
> The optimization can race when multiple kdamonds are running. Meanwhile,
> the impact of the optimization is quite doubtful. Just remove it.
>
> The user impact of the issue should be quite trivial. After all, the race
> can happen only when the user intentionally setup DAMON in the way. Even
> if it happens, it would be rare and only degrade the best-effort
> monitoring results. No critical consequences like kernel panic or memory
> corruption happen.
>
> The race possibility was discovered [1] by Sashiko.
>
> Link: https://lore.kernel.org/20260715031002.108504-4-sj@kernel.org
> Link: https://lore.kernel.org/20260621204050.10993-1-sj@kernel.org [1]
> Fixes: 3f49584b262c ("mm/damon: implement primitives for the virtual memory address spaces")
> Signed-off-by: SJ Park <sj@kernel.org>
> Cc: <stable@vger.kernel.org> # 5.15.x
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> (cherry picked from commit 831846078caa14b7d00b2ccca8b8fe522afe3204)
> Signed-off-by: SJ Park <sj@kernel.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260909060130.269798-1-sj@kernel.org?part=1
next prev parent reply other threads:[~2026-09-09 6:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2026090858-underwent-outlying-c364@gregkh>
2026-09-09 6:01 ` [PATCH 6.12.y] mm/damon/vaddr: drop last same folio access check optimization SJ Park
2026-09-09 6:09 ` sashiko-bot [this message]
2026-09-09 20:26 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260909060952.20DBF1F00A3A@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=damon@lists.linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.