From: sashiko-bot@kernel.org
To: "Naman Jain" <namjain@linux.microsoft.com>
Cc: linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH v4 4/4] x86/irq, iommu/amd, x86/hyperv, PCI: Drop redundant irq_retrigger inits
Date: Wed, 09 Sep 2026 06:52:28 +0000 [thread overview]
Message-ID: <20260909065228.E4C0B1F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260909064448.1004-5-namjain@linux.microsoft.com>
> With fixup_irqs(), msi_set_affinity() and the generic resend path
> (try_retrigger()) now all falling back to irq_chip_retrigger_hierarchy(),
> installing it as the irq_retrigger() callback on the outermost domain chips
> is no longer required. The hierarchy walk reaches the x86 vector domain's
> apic_retrigger_irq() for all of these stacked domain chips.
>
> Remove the now redundant irq_retrigger() initializations from the outermost
> domain interrupt chips, including the Hyper-V root partition PCI/MSI chip.
>
> No functional change intended.
>
> Suggested-by: Thomas Gleixner <tglx@kernel.org>
> Reviewed-by: Shradha Gupta <shradhagupta@linux.microsoft.com>
> Reviewed-by: Thomas Gleixner <tglx@kernel.org>
> Signed-off-by: Naman Jain <namjain@linux.microsoft.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260909064448.1004-1-namjain@linux.microsoft.com?part=4
next prev parent reply other threads:[~2026-09-09 6:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 6:44 [PATCH v4 0/4] x86/irq: Fix lost interrupts on CPU hot-unplug Naman Jain
2026-09-09 6:44 ` [PATCH v4 1/4] x86/hyperv: Set irq_retrigger for root partition PCI/MSI irqchip Naman Jain
2026-09-09 6:53 ` sashiko-bot
2026-09-10 7:11 ` Nam Cao
2026-09-09 6:44 ` [PATCH v4 2/4] x86/irq: Fall back to irq_chip_retrigger_hierarchy() in fixup_irqs() Naman Jain
2026-09-09 6:54 ` sashiko-bot
2026-09-09 6:44 ` [PATCH v4 3/4] x86/irq: Fall back to irq_chip_retrigger_hierarchy() in msi_set_affinity() Naman Jain
2026-09-09 6:51 ` sashiko-bot
2026-09-09 6:44 ` [PATCH v4 4/4] x86/irq, iommu/amd, x86/hyperv, PCI: Drop redundant irq_retrigger inits Naman Jain
2026-09-09 6:52 ` sashiko-bot [this message]
2026-09-13 22:48 ` [PATCH v4 0/4] x86/irq: Fix lost interrupts on CPU hot-unplug Wei Liu
2026-09-14 10:30 ` Naman Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260909065228.E4C0B1F00A3A@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=namjain@linux.microsoft.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.