Re: [PATCH net-next V4 14/14] selftests: drv-net: Add PSP HW GRO conformance tests

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] Hardcoded PSP versions [0, 1] in test_psp_ver_diff instead of dynamically using supported capabilities.
- [Medium] Unconditional creation of AF_INET6 socket crashes on IPv6-disabled systems.
--

commit 2fbb01e97add94de0a14266aa0b2565a8246c7ea
Author: Cosmin Ratiu <cratiu@nvidia.com>

selftests: drv-net: Add PSP HW GRO conformance tests

This commit adds PSP conformance tests to kselftests using the gro helper
binary in --psp mode. The sender crafts encapsulated and SW-encrypted PSP
packets, and the receiver's device decrypts and decapsulates the packets
before an AF_PACKET tap gets to analyze them.

[ ... ]

> diff --git a/tools/testing/selftests/drivers/net/hw/psp_gro.py b/tools/testing/selftests/drivers/net/hw/psp_gro.py
> new file mode 100755
> index 0000000000000..3a069c944ae1e
> --- /dev/null
> +++ b/tools/testing/selftests/drivers/net/hw/psp_gro.py

[ ... ]

> +def _psp_assoc(cfg, version=0):
> +    # This socket receives no traffic, exists solely to own the rx assoc.
> +    s = socket.socket(socket.AF_INET6, socket.SOCK_STREAM)

[Severity: Medium]
Will unconditionally creating an AF_INET6 socket here crash the test framework
with an OSError (EAFNOSUPPORT) on systems where IPv6 is disabled at boot?

If the test is running an IPv4 variant on such a system, should the socket
creation match the protocol family, or gracefully skip the test instead of
failing?

[ ... ]

> +@ksft_variants(_ip_variants())
> +def test_psp_ver_diff(cfg, protocol):
> +    """Frames from two different PSP versions must not coalesce."""
> +    init_psp_dev(cfg)
> +    if len(cfg.psp_info['psp-versions-cap']) < 2:
> +        raise KsftSkipEx("Device supports a single PSP version")
> +
> +    _run(cfg, "psp_ver_diff", protocol, [0, 1])

[Severity: Medium]
Could this hardcoded list of versions [0, 1] cause the test to fail on
devices that support multiple versions but do not support version 0 (for
example, if they only support versions 1 and 2)?

Since the test verifies len(cfg.psp_info['psp-versions-cap']) < 2 to ensure
at least two versions are supported, would it be better to dynamically pick
the first two versions from that capabilities array instead of hardcoding them?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908065244.3799142-1-tariqt@nvidia.com?part=14