From: Simon Horman <horms@kernel.org>
To: Ratheesh Kannoth <rkannoth@marvell.com>
Cc: netdev-bot+sashiko@kernel.org, davem@davemloft.net,
hkelam@marvell.com, linux-kernel@vger.kernel.org,
naveenm@marvell.com, netdev@vger.kernel.org,
sgoutham@marvell.com, andrew+netdev@lunn.ch, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com
Subject: Re: [PATCH v4 net] octeontx2-pf: reset HTB scheduler topology before freeing queues
Date: Wed, 9 Sep 2026 07:57:51 +0100 [thread overview]
Message-ID: <20260909065751.GF40544@horms.kernel.org> (raw)
In-Reply-To: <aqDPtg2y3Pl5_r-j@rkannoth-OptiPlex-7090>
On Wed, Sep 09, 2026 at 08:47:10AM +0530, Ratheesh Kannoth wrote:
> On 2026-09-08 at 22:37:40, netdev-bot+sashiko@kernel.org (netdev-bot+sashiko@kernel.org) wrote:
> > Thank you for your contribution! Sashiko AI review found 2 potential
> > issue(s) to consider:
> >
> > Critical: 0 · High: 1 · Medium: 1 · Low: 0
> >
> > - [High] Incomplete fix: the stale-TOPOLOGY bug class the commit claims
> > to close stays reachable through the AF's bulk release path.
> AF's built release path is FLR/PCI reset path. We will fix it as seperate fix.
>
> > - [Medium] Set/reset asymmetry at the aggregation level: HTB offload
> > programs NIX_AF_TL1X_TOPOLOGY (PRIO_ANCHOR/RR_PRIO) on the shared per-…
> We can't clear TL1 blindly as it is a shared resource between PF and VF.
Thanks for looking into those concerns, and moreover addressing Sashiko's
feedback on earlier revisions of this patch.
This version looks good to me.
Reviewed-by: Simon Horman <horms@kernel.org>
...
next prev parent reply other threads:[~2026-09-09 6:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 2:05 [PATCH v4 net] octeontx2-pf: reset HTB scheduler topology before freeing queues Ratheesh Kannoth
2026-09-08 17:07 ` netdev-bot+sashiko
2026-09-09 3:17 ` Ratheesh Kannoth
2026-09-09 6:57 ` Simon Horman [this message]
2026-09-10 1:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260909065751.GF40544@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkelam@marvell.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=naveenm@marvell.com \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rkannoth@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.