From: sashiko-bot@kernel.org
To: "Andrei Stancovici" <andrei.stancovici@analog.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v4 1/3] dt-bindings: iio: adc: lltc,ltc2497: add LTC2499 to title
Date: Wed, 09 Sep 2026 08:32:28 +0000 [thread overview]
Message-ID: <20260909083228.D7D731F00AC4@smtp.kernel.org> (raw)
In-Reply-To: <20260909082755.366269-2-andrei.stancovici@analog.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message claims to update the title to match the set of documented devices, but it fails to include LTC2305.
--
commit ed7e1178510ad0fd945eab7467d3323be2dec391
Author: Andrei Stancovici <andrei.stancovici@analog.com>
dt-bindings: iio: adc: lltc,ltc2497: add LTC2499 to title
The LTC2499 is already listed in the compatible enum and covered by the
description, but was missing from the binding title. Add it so the title
matches the set of devices the schema documents. No schema or property
change is needed.
> diff --git a/Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml b/Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml
> index c884b6e037670..8aa1ba0a87284 100644
> --- a/Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml
> @@ -4,7 +4,7 @@
> $id: http://devicetree.org/schemas/iio/adc/lltc,ltc2497.yaml#
> $schema: http://devicetree.org/meta-schemas/core.yaml#
>
> -title: Linear Technology / Analog Devices LTC2497 and LTC2309 ADC
> +title: Linear Technology / Analog Devices LTC2497, LTC2499 and LTC2309 ADC
[Severity: Medium]
The commit message states that adding LTC2499 makes the title match the set
of devices the schema documents. However, is this update complete?
Looking at the compatible enum further down in the same file:
properties:
compatible:
enum:
- lltc,ltc2305
- lltc,ltc2309
- lltc,ltc2497
- lltc,ltc2499
LTC2305 is also documented by the schema but remains omitted from the title.
Should the title be updated to include LTC2305 as well to fully match the
commit message's stated goal?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260909082755.366269-1-andrei.stancovici@analog.com?part=1
next prev parent reply other threads:[~2026-09-09 8:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 8:27 [PATCH v4 0/3] iio: adc: add LTC2499 features support Andrei Stancovici
2026-09-09 8:27 ` [PATCH v4 1/3] dt-bindings: iio: adc: lltc,ltc2497: add LTC2499 to title Andrei Stancovici
2026-09-09 8:32 ` sashiko-bot [this message]
2026-09-09 8:27 ` [PATCH v4 2/3] iio: adc: ltc2497: add LTC2499 internal temperature channel Andrei Stancovici
2026-09-09 8:39 ` sashiko-bot
2026-09-09 8:27 ` [PATCH v4 3/3] iio: adc: ltc2497: add 2x conversion speed mode Andrei Stancovici
2026-09-09 14:04 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260909083228.D7D731F00AC4@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=andrei.stancovici@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.