From: David Laight <david.laight.linux@gmail.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Borislav Petkov <bp@alien8.de>,
Mauricio Faria de Oliveira <mfo@igalia.com>,
Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, Juergen Gross <jgross@suse.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Jan Beulich <jbeulich@suse.com>, Brian Gerst <brgerst@gmail.com>,
kernel-dev@igalia.com, linux-kernel@vger.kernel.org,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v9 2/5] x86/asm, x86/boot: expose inline memcmp()
Date: Wed, 9 Sep 2026 09:38:31 +0100 [thread overview]
Message-ID: <20260909093831.095b89cb@pumpkin> (raw)
In-Reply-To: <e74c5a6b-ed9c-40c6-b9d7-ff04ee8c099e@zytor.com>
On Tue, 8 Sep 2026 16:16:51 -0700
"H. Peter Anvin" <hpa@zytor.com> wrote:
> On 2026-09-08 12:32, Borislav Petkov wrote:
> > On Tue, Sep 08, 2026 at 03:04:53PM -0300, Mauricio Faria de Oliveira wrote:
> >> Boris, perhaps the approach here could be changed to add an actual
> >> memcmp()-like inline implementation (e.g., as provided in a previous
> >> revision, without return value differences), or continue with the
> >> memeq()-like memcmp() from arch/x86/boot/ but rename it to memeq() ?
> >
> > Nah, new functionality is not needed. We can add it later when it is really needed.
> >
>
> I personally think it would be a good reason to explicitly rename it memeq(),
> after all it indicates what it actually *does*.
>
> bool memeq(const void *m1, const void *m2, size_t n);
>
> Note, however, that the sense of the return value is opposite -- true means
> equal, so !memcmp(...) needs to be replaced with memeq(...) and vice versa.
>
> The other issue is when gcc/clang wants to call memcmp() out of line. Although
> a theoretical concern, there really isn't any reason not to DTRT there since
> there is only one instance in the code, ever.
>
> Here is an out-of-line compact memcmp() which works for both 16/32 and 64 bits:
>
> int memcmp(const void *s1, const void *s2, size_t len)
> {
> int rv;
>
> asm volatile("xor %0,%0 ; "
> "test %3, %3 ; " /* Handle len == 0 correctly */
That comment doesn't really say what the instruction is for.
The XOR sets Z and clears C (I just checked) so it isn't needed
in order to get the correct flags.
> "repe cmpsb ; "}g
> "setz %b0 ; "
> "sbb $0, %0"
That pair is just wrong.
Only one of C or Z can be set, so I think this is ok:
"seta %b0 ; " /* C == 0 && Z == 0 */
"sbb $0, %0"
> : "=&r" (rv), "+D" (s1), "+S" (s2), "+c" (len)
> : : "cc", "memory");
>
> return rv;
> }
>
> On 64 bits it compiles to:
>
> 0000000000000000 <memcmp>:
> 0: 48 89 d1 mov %rdx,%rcx
> 3: 31 d2 xor %edx,%edx
> 5: 31 c0 xor %eax,%eax
> 7: f3 a6 repz cmpsb (%rdi),(%rsi)
> 9: 0f 97 c2 seta %dl
> c: 0f 92 c0 setb %al
> f: 29 d0 sub %edx,%eax
That isn't the object code from the source ...
David
next prev parent reply other threads:[~2026-09-09 8:38 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-22 18:33 [PATCH v9 0/5] x86/pvh: fix unbootable VMs again (PVH + KASAN) Mauricio Faria de Oliveira
2026-08-22 18:33 ` [PATCH v9 1/5] x86/boot: Remove "cc" clobber from memcmp() Mauricio Faria de Oliveira
2026-09-01 13:16 ` Jan Beulich
2026-09-02 8:33 ` David Laight
2026-09-02 14:18 ` H. Peter Anvin
2026-09-02 2:31 ` Borislav Petkov
2026-09-02 13:29 ` Michael Matz
2026-09-02 13:48 ` Mauricio Faria de Oliveira
2026-09-03 0:01 ` Borislav Petkov
2026-09-03 0:07 ` Mauricio Faria de Oliveira
2026-09-03 0:39 ` Borislav Petkov
2026-09-03 8:40 ` David Laight
2026-09-02 23:58 ` Borislav Petkov
2026-08-22 18:33 ` [PATCH v9 2/5] x86/asm, x86/boot: expose inline memcmp() Mauricio Faria de Oliveira
2026-09-06 17:01 ` Borislav Petkov
2026-09-06 18:15 ` H. Peter Anvin
2026-09-08 18:04 ` Mauricio Faria de Oliveira
2026-09-08 19:32 ` Borislav Petkov
2026-09-08 21:06 ` Mauricio Faria de Oliveira
2026-09-10 3:38 ` Borislav Petkov
2026-09-10 13:07 ` Mauricio Faria de Oliveira
2026-09-10 14:03 ` H. Peter Anvin
2026-09-08 23:16 ` H. Peter Anvin
2026-09-09 8:38 ` David Laight [this message]
2026-09-09 13:43 ` H. Peter Anvin
2026-09-09 19:28 ` David Laight
2026-09-09 19:33 ` H. Peter Anvin
2026-09-09 21:39 ` David Laight
2026-09-09 23:12 ` H. Peter Anvin
2026-09-08 17:57 ` Mauricio Faria de Oliveira
2026-08-22 18:33 ` [PATCH v9 3/5] x86/asm: group inline string functions Mauricio Faria de Oliveira
2026-08-22 18:33 ` [PATCH v9 4/5] x86/cpuid: fix unbootable VMs by really inlining memcmp() in hypervisor_cpuid_base() Mauricio Faria de Oliveira
2026-09-11 4:38 ` Borislav Petkov
2026-09-14 11:22 ` Mauricio Faria de Oliveira
2026-09-15 5:11 ` Borislav Petkov
2026-09-15 8:43 ` David Laight
2026-09-15 15:48 ` Borislav Petkov
2026-09-15 23:49 ` Mauricio Faria de Oliveira
2026-09-16 0:04 ` Borislav Petkov
2026-09-16 0:52 ` Mauricio Faria de Oliveira
2026-08-22 18:33 ` [PATCH v9 5/5] x86/pvh: fix unbootable VMs by really inlining memset() in xen_prepare_pvh() Mauricio Faria de Oliveira
2026-09-11 4:39 ` Borislav Petkov
2026-09-14 11:40 ` Mauricio Faria de Oliveira
2026-09-15 5:26 ` Borislav Petkov
2026-09-15 23:55 ` Mauricio Faria de Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260909093831.095b89cb@pumpkin \
--to=david.laight.linux@gmail.com \
--cc=adobriyan@gmail.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=kernel-dev@igalia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mfo@igalia.com \
--cc=mingo@redhat.com \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.