Re: [PATCH v3 1/2] Input: soc_button_array - fix MS Surface Pro 11 probe failure

[Sergey Lebedev <lsa.uz@pm.me>]

Hans,

It fixes it. Sixteen consecutive boots on the Surface Pro 11, every one with
both gpio-keys devices present and MSHW0040:00 bound. The baseline in my
report was 13 boots in 40.

  boots                     16
  buttons appeared          16
  first input at            1.242 - 1.377 s

For comparison the 13 stock successes ran 1.28 - 1.78 s, so no boot here was
slower than stock managed when it worked, and the spread is tighter. The unit
that binds this device by hand was disabled for the whole run, so nothing
masked the result.

Built on 7.0.0-30, Ubuntu 26.04; both patches apply to that kernel's copy of
the file as-is, 2/2 at an offset. Ubuntu ships the file unmodified - an
out-of-tree build of mainline v7.0's source carries the same srcversion as
Ubuntu's own module - so the tested source differs from stock by your patches
and nothing else.

One note for whoever tests this driver next rather than about the patch: on
this install soc_button_array is in the initramfs under MODULES=most, so
replacing the module under /lib/modules does nothing until update-initramfs
runs, and modinfo will report the new one while the old one is loaded. Three
boots of mine were recorded before I noticed. I checked
/sys/module/soc_button_array/srcversion on every boot above.

Patch 2/2 was in the same build and caused no regression, but I am not
claiming a test for it: the buttons appear here, so this machine's ACPI
descriptor package is not empty and the new check is never reached. So for
1/2 only:

Tested-by: Sergey Lebedev <lsa.uz@pm.me>

Sergey