Re: [PATCH 1/4] dt-bindings: ufs: Add nvidia,tegra264-ufs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing dependency on header file in DT binding example causes dt_binding_check to fail.
--

commit 3569ef54ab3548dc631c5780b8e85a8fb366de60
Author: Kartik Rajput <kkartik@nvidia.com>

dt-bindings: ufs: Add nvidia,tegra264-ufs

This commit adds the device tree binding for the UFS host controller on
NVIDIA Tegra264 SoCs. The controller supports UFS 3.1 up to HS-G4B on two
data lanes.

> diff --git a/Documentation/devicetree/bindings/ufs/nvidia,tegra264-ufs.yaml b/Documentation/devicetree/bindings/ufs/nvidia,tegra264-ufs.yaml
> new file mode 100644
> index 0000000000000..5a9837cb43dd3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/ufs/nvidia,tegra264-ufs.yaml

[ ... ]

> +examples:
> +  - |
> +    #include <dt-bindings/clock/nvidia,tegra264.h>
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +    #include <dt-bindings/phy/nvidia,tegra264-mphy.h>

[Severity: Low]
Does this missing header dependency cause a build failure?

The YAML example includes <dt-bindings/phy/nvidia,tegra264-mphy.h> here in
Documentation/devicetree/bindings/ufs/nvidia,tegra264-ufs.yaml, which does
not exist in the source tree and is not added by this patch series.

When running make dt_binding_check, this will cause the tool to fail
with a preprocessor error due to the missing header.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260909-tegra264-ufs-v1-0-e4a9831702a0@nvidia.com?part=1