From: Alex Markuze <amarkuze@redhat.com>
To: Guanglei Zhu <zhugl3@xiaopeng.com>
Cc: ceph-devel@vger.kernel.org
Subject: Re: [PATCH 1/2] ceph: clamp the inline data length in ceph_fill_inline_data()
Date: Wed, 9 Sep 2026 12:28:57 +0000 [thread overview]
Message-ID: <20260909122857.3964737-1-amarkuze@redhat.com> (raw)
In-Reply-To: <20260908062119.402027-1-zhugl3@xiaopeng.com>
Hi Guanglei,
NACK. Please respin.
1. fs/ceph/addr.c: ceph_fill_inline_data (1/2)
This does not apply to current testing. The helper already takes a
folio and memcpy_to_folio(). Clamp to folio_size(folio), not a
kmap_atomic() PAGE_SIZE page.
2. fs/ceph/addr.c: ceph_netfs_issue_op_inline (2/2)
The new start >= inline_len path leaves err at 0, so the subreq
completes success with no progress. That is EOF for DIO, not the
-ENODATA the commit message claims. Set an error before goto out.
--
Alex Markuze
next prev parent reply other threads:[~2026-09-09 12:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 6:21 [PATCH 1/2] ceph: clamp the inline data length in ceph_fill_inline_data() Guanglei Zhu
2026-09-08 6:21 ` [PATCH 2/2] ceph: fix out-of-bounds read in ceph_netfs_issue_op_inline() Guanglei Zhu
2026-09-09 12:28 ` Alex Markuze [this message]
2026-09-10 3:00 ` [PATCH v2 1/2] ceph: clamp the inline data length in ceph_fill_inline_data() Guanglei Zhu
2026-09-10 3:00 ` [PATCH v2 2/2] ceph: fix out-of-bounds read in ceph_netfs_issue_op_inline() Guanglei Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260909122857.3964737-1-amarkuze@redhat.com \
--to=amarkuze@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=zhugl3@xiaopeng.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.