From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F924563FBF; Wed, 9 Sep 2026 13:54:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788962071; cv=none; b=YiSGnCdAezPCCVMnzcAUOCqLPYZNY+7Xu5CvuxE+p8ukB5h6N7E7+3EpqmNxS7xWhyp6YprtrSL8tfafAq8fMdPUSG5878lf36nZsenjIF0WmmAG47do98eIoAZ/65q+YqRToBAjAlWNqEpXb3WHBw50vmPbJHWTayOannKmNWA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788962071; c=relaxed/simple; bh=ZgQmi6AMFwQ+rLGZ2Y5r/OcTGbvFO8SSrL7JOv0ZMJM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=haslDDNa0AbfWtHu/ikd+k59lJqhzgg5UDACuUcsXxyafd1m5cx3WbcXfmpYvzRDt2ov0sgrSwft8bJclEMngjZ/lgpAUO3J7HIk98M4/bgZu3p9ue6Q0gT+PYP6yHKGainXxJZcokqw3VwyAOG43r3HVk0RG+tx2WJni+9qElQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=dWGWjriv; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="dWGWjriv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D8AF01F00A3A; Wed, 9 Sep 2026 13:54:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1788962070; bh=fpks2jHaTQVOTauTfUgssBQJWKmXgd+rwaTHhEUaf2Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=dWGWjrivcduhH+keqzg1gx1AnrsX6c6SoJx5X87O2jPcNyrzuwJ+aULQOafUP8G/Y y+03hnhPEw5TdmMc0cwX21s0q4Mqq5CRPFAV0iorV7KBwBedTzwBG/xc6Hn8HAGugX bVFIQscoNb5xEMrus0axGTPoHgIx7cMGALg7/r9g= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Kazuki Hanai , Sagi Grimberg , Christoph Hellwig , Keith Busch Subject: [PATCH 7.2 161/556] nvmet-auth: Synchronize timeout work during SQ teardown Date: Wed, 9 Sep 2026 15:37:21 +0200 Message-ID: <20260909134236.087775728@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260909134230.441546314@linuxfoundation.org> References: <20260909134230.441546314@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.2-stable review patch. If anyone has any objections, please let me know. ------------------ From: Kazuki Hanai commit eaa948c0e19b1bb2d93262207bca0c3d19cc3406 upstream. nvmet_auth_sq_free() cancels auth_expired_work with cancel_delayed_work(). If the work has already started, cancellation does not wait for the callback. Transport teardown can consequently free or reuse the queue containing struct nvmet_sq while nvmet_auth_expired_work() still accesses that SQ. Add a teardown-specific helper that synchronously drains the delayed work before freeing authentication state, and use it from nvmet_sq_destroy(). Keep the non-synchronous helper for in-band authentication state cleanup, where the SQ owner remains alive. Fixes: 1a70200f404a ("nvmet-auth: expire authentication sessions") Cc: stable@vger.kernel.org Signed-off-by: Kazuki Hanai Reviewed-by: Sagi Grimberg Reviewed-by: Christoph Hellwig Signed-off-by: Keith Busch Signed-off-by: Greg Kroah-Hartman --- drivers/nvme/target/auth.c | 6 ++++++ drivers/nvme/target/core.c | 2 +- drivers/nvme/target/nvmet.h | 2 ++ 3 files changed, 9 insertions(+), 1 deletion(-) --- a/drivers/nvme/target/auth.c +++ b/drivers/nvme/target/auth.c @@ -238,6 +238,12 @@ void nvmet_auth_sq_free(struct nvmet_sq sq->dhchap_skey = NULL; } +void nvmet_auth_sq_destroy(struct nvmet_sq *sq) +{ + cancel_delayed_work_sync(&sq->auth_expired_work); + nvmet_auth_sq_free(sq); +} + void nvmet_destroy_auth(struct nvmet_ctrl *ctrl) { ctrl->shash_id = 0; --- a/drivers/nvme/target/core.c +++ b/drivers/nvme/target/core.c @@ -977,7 +977,7 @@ void nvmet_sq_destroy(struct nvmet_sq *s wait_for_completion(&sq->confirm_done); wait_for_completion(&sq->free_done); percpu_ref_exit(&sq->ref); - nvmet_auth_sq_free(sq); + nvmet_auth_sq_destroy(sq); nvmet_cq_put(sq->cq); /* --- a/drivers/nvme/target/nvmet.h +++ b/drivers/nvme/target/nvmet.h @@ -915,6 +915,7 @@ u8 nvmet_setup_auth(struct nvmet_ctrl *c void nvmet_auth_sq_init(struct nvmet_sq *sq); void nvmet_destroy_auth(struct nvmet_ctrl *ctrl); void nvmet_auth_sq_free(struct nvmet_sq *sq); +void nvmet_auth_sq_destroy(struct nvmet_sq *sq); int nvmet_setup_dhgroup(struct nvmet_ctrl *ctrl, u8 dhgroup_id); bool nvmet_check_auth_status(struct nvmet_req *req); int nvmet_auth_host_hash(struct nvmet_req *req, u8 *response, @@ -941,6 +942,7 @@ static inline void nvmet_auth_sq_init(st } static inline void nvmet_destroy_auth(struct nvmet_ctrl *ctrl) {}; static inline void nvmet_auth_sq_free(struct nvmet_sq *sq) {}; +static inline void nvmet_auth_sq_destroy(struct nvmet_sq *sq) {}; static inline bool nvmet_check_auth_status(struct nvmet_req *req) { return true;