From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 561175678E5; Wed, 9 Sep 2026 14:00:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788962420; cv=none; b=VlTEGhy2r6EK09g5KwC7k7mKSOV4m9UKawft9QM8PGo1FqgGL0OD80L0Z0ZF5nT0LiRvuh2UoTNz1DBUXxGcElrqi06BB0r2Mkxq41G2sG2ZinW3MCHYnTazzjrK1DuJqDq1r2eXIfRdBG+L2m8OauRkxXGjq0D7zxuOzJBS/w4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788962420; c=relaxed/simple; bh=dU9e9teSaN7SMW5FauWw3vlQOoDuIEliKvmr8wq812o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WxXX/igt9RAVfc3QhHOm4KmWwaOjeLYqj3auieWLTDs58AN4pb3zRG0qXK6fj4d0qtYzv+SVGQch/VPgtAtqRG89Tj+l48CzRgGQ/BxIuEmyiyxiVnyB1w3VsV4SOp/Ue530okzxJMD18EJdIgg93bQbxjnu3vLu8egx9T5XvmU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=xF0KS22e; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="xF0KS22e" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A510C1F00A3A; Wed, 9 Sep 2026 14:00:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1788962419; bh=8Jt+lQdEBmmwJ1KamX1WOw+AUmBxys/fJ9IQbQlXmRo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=xF0KS22elL48Sh2PYxosdjaeaJanzXMLmziVuVmKm3pVIGcvngsu1BBaaTyaHfK1a LWXiZtmJ7y8o0CpNiLbVdXUMP9puZGJI2BQyPLovAQ0vurJoL4iJ3QFAV3AG4Nrrgj HHXGKaXHJII3A3xV9hkCGj2wJC3WaZKPzO8Jm8s4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Maxwell Doose , Andy Shevchenko , Sanjay Chitroda , Srinivas Pandruvada , Jonathan Cameron Subject: [PATCH 7.2 283/556] iio: temperature: hid-sensor-temperature: switch to non-devm iio_device_register() Date: Wed, 9 Sep 2026 15:39:23 +0200 Message-ID: <20260909134240.613836895@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260909134230.441546314@linuxfoundation.org> References: <20260909134230.441546314@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.2-stable review patch. If anyone has any objections, please let me know. ------------------ From: Sanjay Chitroda commit 967d066f5334740f656577bc51c381a1bb707b61 upstream. Avoid using devm_iio_device_register(), as this driver requires explicit error handling and teardown ordering. With devm_iio_device_register(), IIO device remains registered until the devres cleanup phase. However, driver's remove() callback removes the sensor hub callback and trigger support. This can create a race window where IIO device is still visible and read_raw() requests are issued. These requests might call sensor_hub_input_attr_get_raw_value(), which waits up to 5 seconds for a response from the sensor hub callback that has already been removed. Add an explicit iio_device_unregister() call in the teardown path to ensure deterministic cleanup, so that userspace can no longer access the device once backend resources begin to be dismantled. Fixes: 59d0f2da3569 ("iio: hid: Add temperature sensor support") Cc: stable@vger.kernel.org Reviewed-by: Maxwell Doose Reviewed-by: Andy Shevchenko Signed-off-by: Sanjay Chitroda Acked-by: Srinivas Pandruvada Signed-off-by: Jonathan Cameron Signed-off-by: Greg Kroah-Hartman --- drivers/iio/temperature/hid-sensor-temperature.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/iio/temperature/hid-sensor-temperature.c +++ b/drivers/iio/temperature/hid-sensor-temperature.c @@ -243,7 +243,7 @@ static int hid_temperature_probe(struct if (ret) goto error_remove_trigger; - ret = devm_iio_device_register(indio_dev->dev.parent, indio_dev); + ret = iio_device_register(indio_dev); if (ret) goto error_remove_callback; @@ -263,6 +263,7 @@ static void hid_temperature_remove(struc struct iio_dev *indio_dev = platform_get_drvdata(pdev); struct temperature_state *temp_st = iio_priv(indio_dev); + iio_device_unregister(indio_dev); sensor_hub_remove_callback(hsdev, HID_USAGE_SENSOR_TEMPERATURE); hid_sensor_remove_trigger(indio_dev, &temp_st->common_attributes); }