From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 386F6424D48; Wed, 9 Sep 2026 14:03:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788962630; cv=none; b=VQrmbL2Wqh7vNfCkDEiFLzykoU2x5KQpemvC5xcIdPGvB2fSzSiz+dFd9FaPdIa9Wj9B5xvcw51d5ZRY+lKZxxc6jF7qzhYy6/OpKhaZ+j4W4oPSYj9JihJ5OB1PHrE8o0VOYZgTw97a3Sa6Q72uh+F3mNAr/4YCgGtkTm1oTG8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788962630; c=relaxed/simple; bh=uh51+7bTWpMXfpkGg/ZBJ/DeNsqtXhRyAuJKinrGayQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VJ8wgcivOnNBoqF+wqq+HVlkhs1HoCkVPSrEObMnMBQkruVNAId7PL8R5Ug8Ft9iKEMcZvgYWIOrbHnKNbNrnFDJXfobrWDGiIJ5SvQTEFc10uSHfSg3jngloj74lW+x0IFp8Fb3dwlTIg/xFfMYU5vhO+hnfPWOXMcLp2w6Gmc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=GEZ9R/N6; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="GEZ9R/N6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 912131F00A3D; Wed, 9 Sep 2026 14:03:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1788962628; bh=k97jPyafleuaO6NhDjRPyynvGN4+gMTtdQjshoE3zEI=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=GEZ9R/N69m/tI2sZP3CXw3C7M/SKf5hFWss/Xake+oPcW8sDi6HRFEtfbh27MtSDF 7Q4LcjNLS4tBMWa5LnoeDB6XmMlD2Tpo7nVnM88tYLp+GEvntz6KpghI7fdm/WRc4Y FAKauonBNGGjSJMYqX1RokF1OuQFYE706pCAp1jc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Fan Wu , Hans Verkuil Subject: [PATCH 7.2 357/556] media: cx23885: cancel NetUP CI work before teardown Date: Wed, 9 Sep 2026 15:40:37 +0200 Message-ID: <20260909134243.229944929@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260909134230.441546314@linuxfoundation.org> References: <20260909134230.441546314@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.2-stable review patch. If anyone has any objections, please let me know. ------------------ From: Fan Wu commit 4e143d662ca94888b494b2427fc9e34494eb933a upstream. netup_ci_exit() frees a netup_ci_state while its work item, netup_read_ci_status(), may still be pending or running on the system workqueue. The worker obtains the state with container_of() and dereferences it, so it must not outlive the state. netup_ci_init() queues the initial status read, and CI GPIO interrupts subsequently queue the same work from netup_ci_slot_status(). During remove, cx23885_finidev() calls free_irq() before the CI device is unregistered. free_irq() prevents further IRQ handlers from running, but does not drain work queued previously, so the worker can run after netup_ci_exit() frees the state. Call cancel_work_sync() before dvb_ca_en50221_release() and kfree(). This issue was found by an in-house static analysis tool. Fixes: c184dcd28233 ("V4L/DVB (10798): Add CIMax(R) SP2 Common Interface code for NetUP Dual DVB-S2 CI card") Cc: stable@vger.kernel.org Assisted-by: Codex:gpt-5.6 Signed-off-by: Fan Wu Signed-off-by: Hans Verkuil Signed-off-by: Greg Kroah-Hartman --- drivers/media/pci/cx23885/cimax2.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/media/pci/cx23885/cimax2.c +++ b/drivers/media/pci/cx23885/cimax2.c @@ -528,6 +528,7 @@ void netup_ci_exit(struct cx23885_tsport if (NULL == state->ca.data) return; + cancel_work_sync(&state->work); dvb_ca_en50221_release(&state->ca); kfree(state); }