From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8291E5632B5; Wed, 9 Sep 2026 14:04:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788962658; cv=none; b=UmlrclyMQHK1FrXZfFptYGXcHTar8evCP52vA4OylwimEKmjL4B9bkc6EHET+ixeppJ4ck3a1Zmq38VdPFFcqFLP7DA9+stiO42FnM3U8inuLosmLs1HaDzZpXHw1VHLU8ga04llSY086an5lBW6Kb721lMepDB02psXqKFsZfo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788962658; c=relaxed/simple; bh=w0zqreqH08nfH/RmNVOFN0QpXHj37jNIzT/6sQwWf6Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QrpYGhrpj6gIDlBLshrC4c1k1pxoaq6rUnKXLNsvphqg8CxRAqN09VN5d9Qq76/yQdBCE97ORwvMELaW9I1k5Za5s6NJq5VCXVKzkrZf5s5KUIx4BJQ493c2/YM1uw9ThHMWGRswYbzYnikAbaE0AHtJ3fbai7j/PhR2rUH1rnM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Uvauevoe; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Uvauevoe" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 679A21F00A3A; Wed, 9 Sep 2026 14:04:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1788962657; bh=Y52e/RJ/oXle7M1Fe9Q1tOHcNzWB6ATXYJRvClOM+8A=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Uvauevoe7oCjnAQysoEaiykORxxGH/lXaHJRwDO4RdViJvkGmYcvuOOAdKYgv49+q drE51pf34eC44AH3mNsEyIwGGiIetBEINOx3HLRpo7cKPiDQQMioP18j0SdZDvocXe /sOHrqmT5a/qSSDGA3B+EuVvrrQZ85ImyvpamBxs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Biren Pandya , Sakari Ailus Subject: [PATCH 7.2 366/556] media: i2c: ov7740: fix use-after-destroy in remove Date: Wed, 9 Sep 2026 15:40:46 +0200 Message-ID: <20260909134243.550449942@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260909134230.441546314@linuxfoundation.org> References: <20260909134230.441546314@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.2-stable review patch. If anyone has any objections, please let me know. ------------------ From: Biren Pandya commit 5d1b3dea5a44124bab6c14a2d71b977dabed54e7 upstream. The ov7740_remove() function had a severe teardown order bug where it destroyed the driver's mutex before freeing the V4L2 control handler which relies on that mutex, leading to a use-after-destroy kernel panic. Furthermore, the driver explicitly called v4l2_ctrl_handler_free() and mutex_destroy() sequentially, but then called ov7740_free_controls() which invokes both of them a second time, resulting in a double-free. This patch fixes the issue by unregistering the subdevice first, and relying exclusively on ov7740_free_controls() to safely tear down the mutex and control handler in the correct order. Fixes: 39c5c4471b8d ("media: i2c: Add the ov7740 image sensor driver") Cc: stable@vger.kernel.org Signed-off-by: Biren Pandya Signed-off-by: Sakari Ailus Signed-off-by: Greg Kroah-Hartman --- drivers/media/i2c/ov7740.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- a/drivers/media/i2c/ov7740.c +++ b/drivers/media/i2c/ov7740.c @@ -1116,10 +1116,8 @@ static void ov7740_remove(struct i2c_cli struct v4l2_subdev *sd = i2c_get_clientdata(client); struct ov7740 *ov7740 = container_of(sd, struct ov7740, subdev); - mutex_destroy(&ov7740->mutex); - v4l2_ctrl_handler_free(ov7740->subdev.ctrl_handler); - media_entity_cleanup(&ov7740->subdev.entity); v4l2_async_unregister_subdev(sd); + media_entity_cleanup(&ov7740->subdev.entity); ov7740_free_controls(ov7740); pm_runtime_get_sync(&client->dev);