From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6080A566C6B; Wed, 9 Sep 2026 14:06:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788962761; cv=none; b=Xt9SP+BWTz7TTEa/n481ziAiLzxnuz78NHGXY9r4SqckEBvuN9s1aEsOQXljb0jxgMCmkSzZFIYkPwwVp1tutMXzhdANiTXJ8QuHzWoDhnhemMLavHwvS4YOp/bskz40A7plJ+tXXdLWM9eGeClt7GpqZAr2OFl9dPLCfmJKNak= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788962761; c=relaxed/simple; bh=q4yW8OAwM9tZWL0zfjmIjDz3J/ZQieYAPfoVE+W2/oM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=swc7jN7WNKdEQ4JngzXgOzTkgcJ8BPF4QPwwQGHX5LXC2LVbby6prVBLqMjG9T969ER8IBrydfzbZbppDBdNXM0Tt9p7OO/S3e2k7bQ8oRq+nYetMiXl13Tws1ISwu7k2GkhgYq4IqNbAOfqjZmv/YhMgF91KJ2OWy1F6vQcFUM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=KYbDr3A6; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="KYbDr3A6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9C171F00A3A; Wed, 9 Sep 2026 14:05:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1788962760; bh=GZnl/HYzAKwCXBrVrgWKGyEGAJq6fo9r0aWEivHjSCk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=KYbDr3A6k53ylkGCzOLTePItKHfmMItBc1QTANMg7aY3fzb+0jly5rJit8UgN/92O zfKgDzH8WtR8dlUlZV++Fm2QizoOijCvjfQard0sAaap/vSWUU3SaS4jxoQuBKJ0uC DWf7kQZJ8N+mTA6b3QZVdYyCjPXBDoYKZW9f2+Yo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Uday Khare , Hans Verkuil Subject: [PATCH 7.2 403/556] media: video-i2c: fix kthread error pointer left in kthread_vid_cap on failure Date: Wed, 9 Sep 2026 15:41:23 +0200 Message-ID: <20260909134244.808186106@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260909134230.441546314@linuxfoundation.org> References: <20260909134230.441546314@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.2-stable review patch. If anyone has any objections, please let me know. ------------------ From: Uday Khare commit 76e379754ba618989f6215be608d5c04774a611d upstream. kthread_run() returns an ERR_PTR on failure, not NULL. When start_streaming() fails, data->kthread_vid_cap is left holding this error pointer instead of being cleared. This causes two subsequent bugs: 1. A future call to start_streaming() sees a non-NULL kthread_vid_cap and returns 0 (success) immediately, without actually starting the capture thread. 2. A call to stop_streaming() checks 'kthread_vid_cap == NULL' which is false for an error pointer, and proceeds to call kthread_stop() on the error pointer, leading to a kernel crash. Fix this by resetting kthread_vid_cap to NULL on failure before jumping to the error path. Fixes: 5cebaac60974 ("media: video-i2c: add video-i2c driver") Cc: stable@vger.kernel.org Signed-off-by: Uday Khare Signed-off-by: Hans Verkuil Signed-off-by: Greg Kroah-Hartman --- drivers/media/i2c/video-i2c.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) --- a/drivers/media/i2c/video-i2c.c +++ b/drivers/media/i2c/video-i2c.c @@ -522,8 +522,12 @@ static int start_streaming(struct vb2_qu data->kthread_vid_cap = kthread_run(video_i2c_thread_vid_cap, data, "%s-vid-cap", data->v4l2_dev.name); ret = PTR_ERR_OR_ZERO(data->kthread_vid_cap); - if (!ret) - return 0; + if (ret) { + data->kthread_vid_cap = NULL; + goto error_rpm_put; + } + + return 0; error_rpm_put: pm_runtime_put_autosuspend(dev);