From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47500568533; Wed, 9 Sep 2026 14:07:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788962866; cv=none; b=Hbem4YtjMMyU4v9Azx6CB0nDzXn3ZoTjdilk89UpYOBnQ5Hb/FY/serE0O2ckb8bSbTAmTopBqFGVrOn+YLQbftvfPgjbZyiYnSJ8un7fTjlLGhzW6hFc7+eF4Ae5tm+5HyQQtOzXhyJ9bvBvLbUCZuCDq0Wpm1ih9vWV+qb2LA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788962866; c=relaxed/simple; bh=Zp4fTTjRBy+iOLQjR7QsH7oreLyEX0RMx3vWMnbGW6U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IXfWN8q+SzOAnr/Bw64SSZWjXuBicupf7NOTLGoYgVKxe6gxmsNLkHFbxY2UJw3zThDV/3ZgfgiR5N8by75V2KA3x2hGfYvDZyLoeCh4Og4ejd3aBLwt22Xm8vG1TVwj7338marXIBjV+qjgRoOK1I4rnScWAiLm1OCZun9vV+Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=E+3gCYQB; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="E+3gCYQB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A1CAC1F00A3E; Wed, 9 Sep 2026 14:07:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1788962865; bh=GEO+3K7EJ45HsoQ4helLbVhftGpexfAf7c1j15QzG80=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=E+3gCYQBbOHA4r4txmLVMR8YBJPRSGOTsFlD74i5z/91InkqTA/PajE1AchC0twXf XGRylbUh6DUUmy8rRUESHBEI/2yewGQrJAgJD1cd4XD7GC+OIBW1JMEaeBUPyOOtgs 22UkhdZ7QQcvLUyyA1yQhZSJ760axFsO4wjgnUOk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Sashiko , Nilesh Javali , "Martin K. Petersen (Oracle)" Subject: [PATCH 7.2 439/556] scsi: qla2xxx: Avoid req_q_map double-read in qla2x00_error_entry() Date: Wed, 9 Sep 2026 15:41:59 +0200 Message-ID: <20260909134246.050944458@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260909134230.441546314@linuxfoundation.org> References: <20260909134230.441546314@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.2-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nilesh Javali commit deb8abde83a799d2501f3977f6d6051000253f5e upstream. qla2x00_error_entry() reads ha->req_q_map[que] twice: once for the NULL check and again when assigning it to req. The map slot is cleared by qla25xx_free_req_que() (ha->req_q_map[que_id] = NULL under mq_lock) during queue teardown, while the response-queue interrupt that drives qla2x00_error_entry() is still registered (the IRQ is released later in qla25xx_free_rsp_que()). If the slot is set to NULL between the two reads, req becomes NULL and is dereferenced. Read the slot once into req and NULL-check the local before use. mq_lock is a mutex and cannot be taken from interrupt context, so the single read plus local check is the appropriate fix for the reported NULL dereference. Fixes: a6fe35c052c4 ("[SCSI] qla2xxx: Avoid invalid request queue dereference for bad response packets.") Cc: stable@vger.kernel.org Reported-by: Sashiko Signed-off-by: Nilesh Javali Link: https://patch.msgid.link/20260730155838.2119230-17-njavali@marvell.com Signed-off-by: Martin K. Petersen (Oracle) Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/qla2xxx/qla_isr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/scsi/qla2xxx/qla_isr.c +++ b/drivers/scsi/qla2xxx/qla_isr.c @@ -3809,10 +3809,12 @@ qla2x00_error_entry(scsi_qla_host_t *vha "iocb type %xh with error status %xh, handle %xh, rspq id %d\n", pkt->entry_type, pkt->entry_status, pkt->handle, rsp->id); - if (que >= ha->max_req_queues || !ha->req_q_map[que]) + if (que >= ha->max_req_queues) goto fatal; req = ha->req_q_map[que]; + if (!req) + goto fatal; if (pkt->entry_status & RF_BUSY) res = DID_BUS_BUSY << 16;