From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5E5C3F105D; Wed, 9 Sep 2026 14:30:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788964236; cv=none; b=lbe8QMNPTG7/4t/d80ukTttF4GNyXroWg1To3GHpBfc1cRsDmpKKguBdsK+n3/qIaKvoqNB5Aldc7TDStVa+MfVYWGbKx6YyoYjryH2hXIL3xNaq6Zcxfh9MZtvxezTV9S+pj7fP/JmW9U3tGsg3ihLsILAjamJTJ/Fm5VKwcK0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788964236; c=relaxed/simple; bh=SZKryYtG0TNasi61EoXsmkBDeHfnQ/WzxmelebeiGTk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZGswJ3jTtLEzXoaV6a1tw13/SC8prG5tmgcUgEyPYm+DgMOZRFVebnVZdLqIJfKR6bhosxcihiryBDjV7jvKlVZe2NhTEgQLcPcESmMgkkYne4XWls6x0pv3yiqMQ7999kofg3tLjvCRU0MO5DwN7veXj0W/nO3iNIjfyQwjo+s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Nr2nFFDC; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Nr2nFFDC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D8E81F00A3D; Wed, 9 Sep 2026 14:30:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1788964234; bh=o4MEjAgCsPdOKALZ4qGhMY1uuu7uLpeiXFbcCYyXZ1g=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Nr2nFFDCOJ0/xX4Gxifmp2dBe/O0qwYpQ2I+HYrLCz/AtESsSomu3QBw2ihsseMVu dm/J6dE1ZWRuqEXF0wEcnFYmEVwFuXWP73/UOERCN1ouCHbtHjH8rsPHrtgwp6gzrM Heq0YbQ0q9/NEfsCrje5z135Tx7NnIfD3o4qyUg0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Hao-Qun Huang , Chao Yu , Jaegeuk Kim Subject: [PATCH 6.18 352/583] f2fs: reject overlapping move range after len expansion Date: Wed, 9 Sep 2026 15:40:37 +0200 Message-ID: <20260909134250.192715195@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260909134237.773280130@linuxfoundation.org> References: <20260909134237.773280130@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Hao-Qun Huang commit 28c1ef094e7c86977d9bf570dc0362fc54e36437 upstream. F2FS_IOC_MOVE_RANGE treats a zero length as a request to move data from pos_in to EOF. However, the same-file overlap check runs before that expansion, so a request with len == 0 bypasses the overlap rejection added for same-file moves. For example, with a four-block file, moving from block 0 to block 1 with len == 0 is accepted by the old check because pos_in + len is still pos_in at that point. The code then expands len to cover the rest of the file and calls __exchange_data_block() on overlapping source and destination ranges in the same inode, which is the data-corruption case the overlap check was meant to reject. Move the overlap check after the source range has been validated and len == 0 has been expanded, so it sees the effective length. This is a no-op for non-zero len (the value is unchanged there) and keeps the existing early return for identical positions. Fixes: d95fd91c1ac1 ("f2fs: exclude special cases for f2fs_move_file_range") Cc: stable@vger.kernel.org Assisted-by: Claude:claude-fable-5 Signed-off-by: Hao-Qun Huang Reviewed-by: Chao Yu Signed-off-by: Jaegeuk Kim Signed-off-by: Greg Kroah-Hartman --- fs/f2fs/file.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -3119,8 +3119,6 @@ static int f2fs_move_file_range(struct f if (src == dst) { if (pos_in == pos_out) return 0; - if (pos_out > pos_in && pos_out < pos_in + len) - return -EINVAL; } inode_lock(src); @@ -3146,6 +3144,8 @@ static int f2fs_move_file_range(struct f goto out_unlock; if (len == 0) olen = len = src->i_size - pos_in; + if (src == dst && pos_out > pos_in && pos_out < pos_in + len) + goto out_unlock; if (pos_in + len == src->i_size) len = ALIGN(src->i_size, F2FS_BLKSIZE) - pos_in; if (len == 0) {