From: sashiko-bot@kernel.org
To: "Roman Vivchar" <rva333@protonmail.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: iommu: mediatek: add mt6572
Date: Wed, 09 Sep 2026 14:22:49 +0000 [thread overview]
Message-ID: <20260909142249.988F11F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260909-6572-iommu-v1-1-de261da09fb2@protonmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing SMI (Smart Multimedia Interface) bindings for mt6572 alongside the new IOMMU binding.
--
commit a4582297bd41ae5d3cd46c52f5db31a076c1b128
Author: Roman Vivchar <rva333@protonmail.com>
dt-bindings: iommu: mediatek: add mt6572
Add compatible string and header file for mt6572 IOMMU support.
> diff --git a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
> index 79c573c47b08e..d0ac4bd719116 100644
> --- a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
> +++ b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
> @@ -72,6 +72,7 @@ properties:
> - enum:
> - mediatek,mt2701-m4u # generation one
> - mediatek,mt2712-m4u # generation two
> + - mediatek,mt6572-m4u # generation one
[Severity: Medium]
Will device trees for MT6572 fail dt_binding_check because the required SMI
larb nodes lack documented compatible strings for this SoC?
The schema for mediatek,iommu.yaml strictly requires mediatek,larbs for
this IOMMU in its allOf block:
- if: # The IOMMUs don't have larbs.
not:
properties:
compatible:
contains:
enum:
- mediatek,mt8188-iommu-infra
- mediatek,mt8189-iommu-apu
- mediatek,mt8189-iommu-infra
- mediatek,mt8195-iommu-infra
then:
required:
- mediatek,larbs
However, the corresponding SMI bindings (mediatek,smi-larb.yaml and
mediatek,smi-common.yaml) do not appear to have been updated to include
the mt6572 compatible strings needed to define those required larb nodes.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260909-6572-iommu-v1-0-de261da09fb2@protonmail.com?part=1
next prev parent reply other threads:[~2026-09-09 14:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 14:14 [PATCH 0/3] iommu/mediatek-v1: fix the driver + mt6572 support Roman Vivchar
2026-09-09 14:14 ` Roman Vivchar via B4 Relay
2026-09-09 14:14 ` [PATCH 1/3] dt-bindings: iommu: mediatek: add mt6572 Roman Vivchar
2026-09-09 14:14 ` Roman Vivchar via B4 Relay
2026-09-09 14:22 ` sashiko-bot [this message]
2026-09-11 7:27 ` Krzysztof Kozlowski
2026-09-09 14:14 ` [PATCH 2/3] iommu/mediatek-v1: fix IOMMU device binding Roman Vivchar
2026-09-09 14:14 ` Roman Vivchar via B4 Relay
2026-09-09 14:30 ` sashiko-bot
2026-09-09 14:14 ` [PATCH 3/3] iommu/mediatek-v1: add mt6572 support Roman Vivchar
2026-09-09 14:14 ` Roman Vivchar via B4 Relay
2026-09-09 14:32 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260909142249.988F11F00A3A@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rva333@protonmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.