From: sashiko-bot@kernel.org
To: "Judith Mendez" <jm@ti.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 1/1] arm64: dts: ti: k3-am654-base-board: Add power-off delay for proper MMC power cycle
Date: Wed, 09 Sep 2026 17:49:04 +0000 [thread overview]
Message-ID: <20260909174904.708DB1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260909173833.764103-2-jm@ti.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The `power-off-delay-us` property is placed directly in the SDHCI host node where it is silently ignored by the kernel, rendering the intended fix ineffective.
--
commit ad27b5f7c84e8187c60f3d6ec61cfd8ac2996675
Author: Judith Mendez <jm@ti.com>
arm64: dts: ti: k3-am654-base-board: Add power-off delay for proper MMC power cycle
This commit adds a power-off-delay-us property to the SDHCI1 node in the
AM654 base board Devicetree. It intends to ensure the MMC1 VDD rail fully
discharges during power cycles between boot stages.
> diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> index ca1300e130936..edcf039ccfbd0 100644
> --- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> @@ -460,6 +460,7 @@ &sdhci0 {
> &sdhci1 {
> status = "okay";
> vmmc-supply = <&vdd_mmc1_sd>;
> + power-off-delay-us = <650000>;
[Severity: High]
Will this property be parsed by the kernel when placed directly in the host
node?
The power-off-delay-us property is specific to the mmc-pwrseq-simple binding
and is parsed exclusively by drivers/mmc/core/pwrseq_simple.c. Neither the
core MMC code (drivers/mmc/core/host.c) nor the SDHCI host drivers parse
this property directly from the host controller node.
Because it is placed directly under &sdhci1 rather than inside an
mmc-pwrseq-simple node, the kernel will silently ignore it. Does this leave
the MMC initialization failure unresolved?
> pinctrl-names = "default";
> pinctrl-0 = <&main_mmc1_pins_default>;
> ti,driver-strength-ohm = <50>;
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260909173833.764103-2-jm@ti.com?part=1
prev parent reply other threads:[~2026-09-09 17:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 17:38 [PATCH v2 0/1] AM65x MMC power-off delay fix Judith Mendez
2026-09-09 17:38 ` [PATCH v2 1/1] arm64: dts: ti: k3-am654-base-board: Add power-off delay for proper MMC power cycle Judith Mendez
2026-09-09 17:49 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260909174904.708DB1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jm@ti.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.