All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: shuo huang <f64116045@gs.ncku.edu.tw>
Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org, davem@davemloft.net,
	edumazet@google.com, pabeni@redhat.com, horms@kernel.org,
	shuah@kernel.org
Subject: Re: [PATCH net-next] selftests: net: Add TCP payload verification to udpgso_bench_rx
Date: Wed, 9 Sep 2026 18:08:51 -0700	[thread overview]
Message-ID: <20260909180851.01488994@kernel.org> (raw)
In-Reply-To: <20260906145643.219609-1-f64116045@gs.ncku.edu.tw>

On Sun,  6 Sep 2026 22:56:43 +0800 shuo huang wrote:
> udpgso_bench_rx supports UDP payload verification but rejects the
> combination of TCP and verification mode. Its TCP receive path discards
> the payload, so it cannot check the data generated by udpgso_bench_tx.
> 
> Read the TCP payload into a buffer when verification is requested
> and check it against the transmitter's repeating alphabetic
> pattern. Preserve the verification position across recv() calls
> because TCP does not preserve send boundaries. Restart the pattern
> at the payload length supplied with -l, matching the transmitter's
> pattern restart on each message.
> 
> Require a nonzero -l value for TCP verification and retain the existing
> discard path when verification is disabled.

This new option is not exercised by any in-tree test.
Do you have any special use case that needs it?
Otherwise either its useful and in-tree tests should run it, or it's
not useful and we shouldn't merge this patch either..
-- 
pw-bot: cr

  parent reply	other threads:[~2026-09-10  1:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-06 14:56 [PATCH net-next] selftests: net: Add TCP payload verification to udpgso_bench_rx shuo huang
2026-09-07  2:57 ` Jiayuan Chen
2026-09-10  1:08 ` Jakub Kicinski [this message]
2026-09-11 15:53   ` F64116045黃 朔 HUANG SHUO

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260909180851.01488994@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=f64116045@gs.ncku.edu.tw \
    --cc=horms@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.